symengine and symengine_py 0.11 by dimpase · Pull Request #36677 · sagemath/sage

dimpase · 2023-11-08T08:59:31Z

update symengine and symengine_py to the latest versions, support Cython 3

Also, provide spkg-configure for symengine and symengine_py. Closes #32421

Promote symengine_py to optional

dimpase · 2023-11-08T09:01:10Z

in particular, our symengine_py does not work with Cython 3. Upstream master does, not yet released, waiting

dimpase · 2023-11-08T09:04:58Z

let's finish #32421 here

dimpase · 2023-11-20T14:59:47Z

OK, 0.11 is out on PyPI: https://pypi.org/project/symengine/0.11.0/ , will update

dimpase · 2023-11-23T13:21:08Z

if this works on all major platforms we should promote symengine_py to optional

mkoeppe · 2023-11-23T22:47:06Z

More distro packages could be added - https://repology.org/project/python:symengine/versions

tobiasdiez

The tests are currently failing.

src/sage/features/symengine_py.py

Co-authored-by: Tobias Diez <[email protected]>

tobiasdiez · 2023-11-27T13:53:05Z

src/sage/features/symengine_py.py

+        JoinFeature.__init__(self, 'symengine_py',
+                             [PythonModule('symengine', spkg="symengine_py",
+                                            url="https://pypi.org/project/symengine")])


Suggested change

JoinFeature.__init__(self, 'symengine_py',

[PythonModule('symengine', spkg="symengine_py",

url="https://pypi.org/project/symengine")])

JoinFeature.__init__(self, "symengine_py",

[PythonModule("symengine", spkg="symengine_py",

type="experimental",

url="https://pypi.org/project/symengine")])

Untested, to fix:

File "src/sage/doctest/test.py", line 515, in sage.doctest.test Failed example: subprocess.call(["sage", "-t", "--warn-long", "0", "--random-seed=0", "--optional=bad-option", "show_skipped.rst"], **kwds) Expected: Traceback (most recent call last): ... ValueError: invalid optional tag 'bad-option' 1 Got: /home/runner/work/sage/sage/src/sage/features/__init__.py:107: UserWarning: Feature symengine is declared optional, but it is provided by symengine_py, which is declared experimental in SAGE_ROOT/build/pkgs cached = _trivial_unique_representation_cache[key] = type.__call__(cls, *args, **options) /home/runner/work/sage/sage/src/sage/features/symengine_py.py:38: UserWarning: Feature symengine_py is declared optional, but it is provided by symengine_py, which is declared experimental in SAGE_ROOT/build/pkgs JoinFeature.__init__(self, 'symengine_py', Traceback (most recent call last): File "/home/runner/work/sage/sage/src/bin/sage-runtests", line 161, in <module> DC = DocTestController(args, args.filenames) File "/home/runner/work/sage/sage/src/sage/doctest/control.py", line 502, in __init__ raise ValueError('invalid optional tag {!r}'.format(o)) ValueError: invalid optional tag 'bad-option'

how about promoting symengine_py to optional ? then none of this will be needed.

Fine with me as well. By the way, what's the general roadmap concerning maxima vs symengine?

imho we should be going towards symengine to replace pynac, first of all.

no idea how hard this is, though

how about promoting symengine_py to optional

Fine with me

tobiasdiez · 2023-11-29T05:28:27Z

LGTM

dimpase · 2023-11-29T12:53:25Z

thanks

sagemathgh-35848: upgrade to flint3 Upgrade to flint3. Current Sage versions are not compatible with flint ≥ 3, and, though the diff is not huge, there are enough changes that versions including this PR will be incompatible with flint < 3. Fixes sagemath#20003. Closes sagemath#35993 as no longer relevant. Related PRs in upstream projects: * Singular/Singular#1177 * flintlib/flint#1408 * flintlib/flint#1489 * flintlib/flint#1492 * flintlib/flint#1611 * algebraic-solving/msolve#76 * flatsurf/e-antic#264 Additional changes still needed for optional packages to work: * sagemath#36677 * upgrade e-antic * possibly more Planned follow-ups: * sagemath#36449 * sagemath#36433 URL: sagemath#35848 Reported by: Marc Mezzarobba Reviewer(s): Vincent Delecroix

sagemathgh-36677: symengine and symengine_py 0.11 update symengine and symengine_py to the latest versions, support Cython 3 Also, provide spkg-configure for symengine and symengine_py. Closes sagemath#32421 Promote symengine_py to optional URL: sagemath#36677 Reported by: Dima Pasechnik Reviewer(s): Dima Pasechnik, Isuru Fernando, Matthias Köppe, Tobias Diez

kiwifb · 2023-12-07T03:04:04Z

flint 3 has been merged in 10.3.beta0 and symegine-0.11.1 does not support it. But support has been merged in master. So, this will fail in its current state.

isuruf · 2023-12-07T16:50:04Z

Just released symengine-0.11.2 with flint-3 fixes

dimpase · 2023-12-10T11:51:04Z

Just released symengine-0.11.2 with flint-3 fixes

@isuruf - could you please add a stable tarball for this release, not a GitHub's auto-"tarball"?

sagemathgh-36847: Symengine 0.11.2 followup to sagemath#36677 - fix to support flint 3 URL: sagemath#36847 Reported by: Dima Pasechnik Reviewer(s):

mkoeppe · 2024-04-07T02:20:30Z

@vbraun The tarball symengine.py-0.11.0.tar.gz appears to be missing on the mirrors.
https://github.com/mkoeppe/sage/actions/runs/8585436817/job/23526820138#step:5:1792

mkoeppe · 2024-04-07T05:11:38Z

Actually the upstream_url is wrong. I'll fix this in #37762.

dimpase · 2024-04-29T13:01:42Z

@mkoeppe - as long as you block me, I can't review #37762. Therefore I'm forced to open a concurring PR.

dimpase · 2024-04-29T13:14:09Z

URL typo is fixed in #37903

mkoeppe · 2024-04-30T00:44:27Z

@mkoeppe - as long as you block me

@dimpase You know why you are blocked. And it's not going to change until I see that you to make the necessary adjustments to your behavior. I walked you through the details in #36726.

dimpase · 2024-04-30T07:11:27Z

@mkoeppe - you are blocking me because I see the destruction you have brought to the project. I am advocating for getting you suspended, until you realise the harm you are causing.

sagemathgh-37726: sage-bootstrap: update cryptographic hashes       Update cryptographic hashes to use sha256 instead of sha1 due to insecurity of sha1. - Fixes sagemath#37691 - Fixes sagemath#37558, see also sagemath#36677 (comment) ### 📝 Checklist  - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies    - sagemath#37570 - sagemath#37249 - sagemath#37914 URL: sagemath#37726 Reported by: Faisal Reviewer(s): Matthias Köppe, roed314

dimpase added c: packages: experimental c: packages: optional t: bug labels Nov 8, 2023

dimpase marked this pull request as draft November 8, 2023 09:01

dimpase added the c: build: configure label Nov 8, 2023

vbraun force-pushed the develop branch from 883e05f to e349b00 Compare November 12, 2023 16:25

dimpase added 3 commits November 23, 2023 12:29

symengine 0.11.1

87f85b9

spkg-configure for symengine

5d7f730

data for symengine_py from the system

68049b6

dimpase force-pushed the symengine_0_11 branch from 1e1c50d to 68049b6 Compare November 23, 2023 12:29

dimpase added 2 commits November 23, 2023 12:40

symengine_py now on PyPI

065e004

features for symengine_py

aad2903

dimpase marked this pull request as ready for review November 23, 2023 13:17

dimpase added the s: needs review label Nov 23, 2023

dimpase requested review from isuruf and mkoeppe November 23, 2023 13:18

isuruf approved these changes Nov 23, 2023

View reviewed changes

tobiasdiez suggested changes Nov 25, 2023

View reviewed changes

src/sage/features/symengine_py.py Show resolved Hide resolved

src/sage/features/symengine_py.py Outdated Show resolved Hide resolved

Matthias Köppe and others added 3 commits November 26, 2023 19:29

Update src/sage/features/symengine_py.py

071599b

Co-authored-by: Tobias Diez <[email protected]>

more distro info for symengine(_py)

55f70cf

Merge branch 'symengine_0_11' of github.com:dimpase/sage into symeng011

16dd36f

dimpase requested a review from tobiasdiez November 27, 2023 11:56

tobiasdiez reviewed Nov 27, 2023

View reviewed changes

promote symengine_py to optional

f65df40

dimpase removed the s: needs work label Nov 29, 2023

tobiasdiez added the s: positive review label Nov 29, 2023

dimpase mentioned this pull request Dec 9, 2023

Symengine 0.11.2 #36847

Merged

vbraun merged commit e37e94d into sagemath:develop Dec 10, 2023

github-actions bot removed the s: positive review label Dec 10, 2023

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 17, 2023

1b1673b

sagemathgh-36847: Symengine 0.11.2 followup to sagemath#36677 - fix to support flint 3 URL: sagemath#36847 Reported by: Dima Pasechnik Reviewer(s):

dimpase deleted the symengine_0_11 branch April 29, 2024 13:01

dimpase mentioned this pull request Apr 29, 2024

correct URL for symengine_py #37903

Closed

Uh oh!

Comments

Conversation

dimpase commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dimpase commented Nov 8, 2023

Uh oh!

dimpase commented Nov 8, 2023

Uh oh!

dimpase commented Nov 20, 2023

Uh oh!

dimpase commented Nov 23, 2023

Uh oh!

mkoeppe commented Nov 23, 2023

Uh oh!

tobiasdiez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tobiasdiez Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

tobiasdiez Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

dimpase Nov 28, 2023

Choose a reason for hiding this comment

Uh oh!

tobiasdiez Nov 28, 2023

Choose a reason for hiding this comment

Uh oh!

dimpase Nov 28, 2023

Choose a reason for hiding this comment

Uh oh!

mkoeppe Nov 28, 2023

Choose a reason for hiding this comment

Uh oh!

tobiasdiez commented Nov 29, 2023

Uh oh!

dimpase commented Nov 29, 2023

Uh oh!

kiwifb commented Dec 7, 2023

Uh oh!

isuruf commented Dec 7, 2023

Uh oh!

dimpase commented Dec 10, 2023

Uh oh!

mkoeppe commented Apr 7, 2024

Uh oh!

mkoeppe commented Apr 7, 2024

Uh oh!

dimpase commented Apr 29, 2024

Uh oh!

dimpase commented Apr 29, 2024

Uh oh!

mkoeppe commented Apr 30, 2024

Uh oh!

dimpase commented Apr 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dimpase commented Nov 8, 2023 •

edited

Loading