sage.libs.pari, sage.rings.real_mpfr: Modularization fixes#36645
Merged
vbraun merged 15 commits intosagemath:developfrom Dec 10, 2023
Merged
sage.libs.pari, sage.rings.real_mpfr: Modularization fixes#36645vbraun merged 15 commits intosagemath:developfrom
sage.libs.pari, sage.rings.real_mpfr: Modularization fixes#36645vbraun merged 15 commits intosagemath:developfrom
Conversation
added 14 commits
November 3, 2023 21:23
Contributor
Author
|
Thank you! |
Member
|
Merge conflict |
|
Documentation preview for this PR (built with commit 241ac56; changes) is ready! 🎉 |
Member
|
Something weird is happening after this. The file I cleaned up everything to start from scratch in case this was something, but still same failure. |
Contributor
Author
|
Hmm.... it has a |
Contributor
Author
|
Which setup.py do you use? |
Contributor
Author
|
I'll open a PR that fixes this. |
Member
The one in |
Member
Yes, that works. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 13, 2023
sagemathgh-36859: src/sage/libs/pari/convert_sage_matrix.pyx: Remove `sage_setup: distribution` <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> It was added by mistake in sagemath#36645. Thanks for reporting @tornaria <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [ ] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36859 Reported by: Matthias Köppe Reviewer(s):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main change: Eliminate the compile-time dependency of
sage.rings.real_mpfron PARI.📝 Checklist
⌛ Dependencies