sage.algebras: Update # needs, modularization fixes, doctest cosmetics#36642
Merged
vbraun merged 27 commits intosagemath:developfrom Dec 6, 2023
Merged
sage.algebras: Update # needs, modularization fixes, doctest cosmetics#36642vbraun merged 27 commits intosagemath:developfrom
sage.algebras: Update # needs, modularization fixes, doctest cosmetics#36642vbraun merged 27 commits intosagemath:developfrom
Conversation
added 24 commits
November 3, 2023 20:18
…sage.rings.finite_rings,sage.libs.pari --overwrite src/sage/algebras/finite_dimensional_algebras/finite_dimensional_algebra_element.pyx
…ags --probe sage.rings.finite_rings --overwrite src/sage/algebras/finite_dimensional_algebras/finite_dimensional_algebra.py
… doctest cosmetics
kwankyu
reviewed
Nov 9, 2023
| sage: A2 = GradedCommutativeAlgebra(GF(2), ['x', 'y'], [3, 6]) # needs sage.rings.finite_rings | ||
| sage: A1 is A2 # needs sage.rings.finite_rings | ||
| True | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Thanks. Done throughout the file in bd006df
kwankyu
reviewed
Nov 9, 2023
kwankyu
reviewed
Nov 9, 2023
kwankyu
reviewed
Nov 9, 2023
kwankyu
reviewed
Nov 9, 2023
kwankyu
reviewed
Nov 9, 2023
kwankyu
reviewed
Nov 9, 2023
|
|
||
| sage: A.<x,y,z,t> = GradedCommutativeAlgebra(QQ, degrees=(1,2,6,6)) | ||
| sage: A.<x,y,z,t> = GradedCommutativeAlgebra(QQ, degrees=(1,2,6,6)) # needs sage.libs.singular | ||
| sage: type(A) |
Collaborator
There was a problem hiding this comment.
Why sage.libs.singular? sage.modules is not enough?
Contributor
Author
There was a problem hiding this comment.
Can't test right now, so I have removed it in 919ec6f
Collaborator
|
Otherwise, looks good to me. |
added 3 commits
November 12, 2023 14:16
SageMath version 10.2.rc2, Release Date: 2023-11-12
…ings.finite_rings'
…ngular'; doctest cosmetics
|
Documentation preview for this PR (built with commit 919ec6f; changes) is ready! 🎉 |
Collaborator
|
codecov/patch complains decreased coverage in I am testing with 10.2.rc3. |
Contributor
Author
|
Thank you! |
Contributor
Author
I think these fluctuations may be explained by #36539 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies