sage.combinat: Update # needs#36619
Merged
vbraun merged 27 commits intosagemath:developfrom Nov 5, 2023
Merged
Conversation
added 19 commits
October 31, 2023 16:48
dcoudert
suggested changes
Nov 2, 2023
Contributor
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
You should update the description of this PR as you did root_system.
I see the following warning:
sage -t --long --random-seed=275711692312133561019985353296319482447 src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py
**********************************************************************
File "src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py", line 1903, in sage.combinat.root_system.non_symmetric_macdonald_polynomia
ls.NonSymmetricMacdonaldPolynomials.symmetric_macdonald_polynomial
Warning: Variable 'f' referenced here was set only in doctest marked '# needs sage.graphs sage.libs.gap'
fe = f.expand(g.parent().gens()); fe
[559 tests, 13.86 s]
This PR is way too big....
src/sage/combinat/partition.py
Outdated
| sage: Partitions(3).cardinality() # needs sage.libs.flint | ||
| 3 | ||
| sage: Partitions(10).cardinality() | ||
| sage: Partitions(10).cardinality() # needs sage.libs.flint |
Contributor
There was a problem hiding this comment.
This doctest is repeated.
May be we should reorder the doctests to use more block scope.
added 7 commits
November 2, 2023 11:44
Contributor
Author
I've instead taken out the unintended changes in this folder. |
|
Documentation preview for this PR (built with commit 5192865; changes) is ready! 🎉 |
dcoudert
approved these changes
Nov 3, 2023
Contributor
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
Passes all tests on Fedora 35 without warnings in the considered parts of combinat.
LGTM. I hope I have not missed something. This is a giant PR...
Contributor
Author
|
Thanks very much for the patient review of this supersized PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #35095.
Excluding
.{designs,posets,root_system,species,words}, which have been or will be done in separate PRs.📝 Checklist
⌛ Dependencies