sage.modular: Update # needs, doctest cosmetics#36618
Merged
vbraun merged 5 commits intosagemath:developfrom Nov 5, 2023
Merged
sage.modular: Update # needs, doctest cosmetics#36618vbraun merged 5 commits intosagemath:developfrom
sage.modular: Update # needs, doctest cosmetics#36618vbraun merged 5 commits intosagemath:developfrom
Conversation
added 5 commits
October 31, 2023 15:50
…lock tags, docstring cosmetics
|
Documentation preview for this PR (built with commit 4e33539; changes) is ready! 🎉 |
dcoudert
approved these changes
Nov 2, 2023
Contributor
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
The way of describing input parameters could sometimes use a more standard form like
- ``name`` -- type (default: ``value``); description
but this is already much better. So I propose to let that for future PRs.
Passes all tests without warnings in modular.
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #35095.
📝 Checklist
⌛ Dependencies