Replace relative imports by absolute ones in sage.libs except .ntl#36612
Merged
vbraun merged 2 commits intosagemath:developfrom Nov 5, 2023
Merged
Replace relative imports by absolute ones in sage.libs except .ntl#36612vbraun merged 2 commits intosagemath:developfrom
sage.libs except .ntl#36612vbraun merged 2 commits intosagemath:developfrom
Conversation
tobiasdiez
reviewed
Nov 1, 2023
| @@ -0,0 +1,105 @@ | |||
| # sage_setup: distribution = sagemath-pari | |||
Contributor
Author
There was a problem hiding this comment.
slipped in while cherry picking, I'll fix it
|
Documentation preview for this PR (built with commit 486508d; changes) is ready! 🎉 |
tobiasdiez
approved these changes
Nov 2, 2023
Contributor
tobiasdiez
left a comment
tobiasdiez
left a comment
There was a problem hiding this comment.
LGTM. For the next time, please just add another commit fixing the issue instead force-pushing everything. As a referee I don't want to check everything again, only the changed parts (i.e here that you removed the file). Thanks
Contributor
Author
|
As these commits are cherry-picks from #35095, it's more important for me to keep the commits in clear relation to the original commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies