Fix bootstrapping on centos-7, fedora-30, ubuntu-xenial#36476
Merged
vbraun merged 1 commit intosagemath:developfrom Oct 21, 2023
Merged
Fix bootstrapping on centos-7, fedora-30, ubuntu-xenial#36476vbraun merged 1 commit intosagemath:developfrom
centos-7, fedora-30, ubuntu-xenial#36476vbraun merged 1 commit intosagemath:developfrom
Conversation
tobiasdiez
approved these changes
Oct 18, 2023
Contributor
tobiasdiez
left a comment
tobiasdiez
left a comment
There was a problem hiding this comment.
Seems to work well (the macos conda workflow had the same issue, but bootstrap is working there now).
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
centos-7, still supported until June 2024, we have to use sage-bootstrap-python = python2.Support for Python 2 was broken accidentally in #36393, see https://github.com/sagemath/sage/actions/runs/6520548150/job/17767608828#step:10:1927
Fixed here, as tested with
tox -e docker-centos-7-devtoolset-gcc_11-standard -- config.status.Same issue also affects
fedora-30, which is still tested by the CI as a proxy for old RHEL, andubuntu-xenial. See #32074📝 Checklist
⌛ Dependencies