sage.symbolics: Remove code deprecated in #18036, #29738, #32386, #32638, #32665, #34215#36304
Merged
vbraun merged 10 commits intosagemath:developfrom Oct 21, 2023
Merged
Conversation
dcoudert
approved these changes
Oct 6, 2023
Contributor
dcoudert
left a comment
There was a problem hiding this comment.
LGTM.
The reported doctest errors are independent (geng missing on the system)
Contributor
Author
|
Thanks! |
Member
|
Again an obvious fail, propoerly diagnosed by the CI, yet still set to "positive review" and for me to manually figure out whats broken. |
added 10 commits
October 11, 2023 14:36
dcoudert
approved these changes
Oct 15, 2023
Contributor
dcoudert
left a comment
There was a problem hiding this comment.
Sorry for not seeing the issue. I tried on a Fedora desktop: passes all tests, documentation builds well.
Contributor
Author
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 17, 2023
sagemathgh-36304: `sage.symbolics`: Remove code deprecated in sagemath#18036, sagemath#29738, sagemath#32386, sagemath#32638, sagemath#32665, sagemath#34215 <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36304 Reported by: Matthias Köppe Reviewer(s): David Coudert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies