Merged
Conversation
added 30 commits
September 16, 2023 11:39
…only-tags src/sage/sets
dcoudert
suggested changes
Sep 30, 2023
Contributor
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
a few possible improvements. otherwise LGTM.
Contributor
Author
|
Thanks! All done in a330894 |
dcoudert
reviewed
Oct 1, 2023
src/sage/sets/condition_set.py
Outdated
| False | ||
|
|
||
| sage: Interval = ConditionSet(RR, x >= -7, x <= 4, vars=[x]); Interval | ||
| sage: Interval = ConditionSet(RR, x >= -7, x <= 4, vars=[x]); Interval # needs sage.symbolic |
Contributor
There was a problem hiding this comment.
This raises a doctest warning
sage -t --long --warn-long 33.4 --random-seed=204097948585721018066760244858101334890 src/sage/sets/condition_set.py
**********************************************************************
File "src/sage/sets/condition_set.py", line 431, in sage.sets.condition_set.?._sympy_
Warning: Variable 'x' referenced here was set only in doctest marked '# needs sage.modules sage.symbolic'
Interval = ConditionSet(RR, x >= -7, x <= 4, vars=[x]); Interval # needs sage.symbolic
[96 tests, 0.88 s]
My suggestion is to remove the empty line above.
dcoudert
approved these changes
Oct 1, 2023
Contributor
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
no more warnings.
LGTM.
Contributor
Author
|
Thanks for the patient review! |
|
Documentation preview for this PR (built with commit 34e4139; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 1, 2023
sagemathgh-36272: `sage.sets`: Update `# needs` <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> - Part of: sagemath#29705 - Cherry-picked from: sagemath#35095 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36272 Reported by: Matthias Köppe Reviewer(s): David Coudert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies