sage.rings.polynomial: Modularization fixes, # needs#36045
sage.rings.polynomial: Modularization fixes, # needs#36045vbraun merged 58 commits intosagemath:developfrom
sage.rings.polynomial: Modularization fixes, # needs#36045Conversation
…il if singular cannot be imported
…cept for an unpickle_override import
…Space cannot be imported
….combinat into method
…when sage.interfaces.singular is not available
…gs.abc, fix handling of Orders
dcoudert
left a comment
There was a problem hiding this comment.
This is a giant ticket. Can't it be split per sub directories ?
There are several files in which you used # optional and not # needs. Also, block scope could be employed in many places. I noted only a few of these places (too many).
…nomialRing into methods
….abc, fix handling of Orders (fixup)
…ort, add # optional
…ntl' when GF2X is used
…probe sage.rings.finite_rings src/sage/rings/polynomial
There were a few commits with incidental changes in other directories. I have trimmed them away now.
Thanks for your patient review of this megaticket. I've made the indicated changes and many more. |
dcoudert
left a comment
There was a problem hiding this comment.
This is much better, but I noted a few more issues.
|
Documentation preview for this PR (built with commit fafd930; changes) is ready! 🎉 |
|
Thank you! |
sagemathgh-36045: `sage.rings.polynomial`: Modularization fixes, `# needs` <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> - Part of: sagemath#29705 - Cherry-picked from: sagemath#35095 <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36045 Reported by: Matthias Köppe Reviewer(s): David Coudert
📝 Checklist
⌛ Dependencies