sage.graphs: Update # needs, use block-scoped tags#36026
Merged
vbraun merged 10 commits intosagemath:developfrom Aug 5, 2023
Merged
sage.graphs: Update # needs, use block-scoped tags#36026vbraun merged 10 commits intosagemath:developfrom
sage.graphs: Update # needs, use block-scoped tags#36026vbraun merged 10 commits intosagemath:developfrom
Conversation
added 9 commits
August 2, 2023 15:37
…-tags src/sage/graphs/generators/classical_geometries.py; ./sage -fixdoctests src/sage/graphs/generators/classical_geometries.py
…es]' src/sage/graphs/generators/smallgraphs.py; ./sage -fixdoctests src/sage/graphs/generators/smallgraphs.py
dcoudert
approved these changes
Aug 3, 2023
Contributor
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
There are few places where block tags would certainly be nicer, but it's a matter of preferences.
Let's hope this giant PR will not cause too many conflicts with other open PR on graphs...
| sage: from sage.graphs.connectivity import is_connected | ||
| sage: empty = Graph() | ||
| sage: vertex_connectivity(empty) | ||
| sage: vertex_connectivity(empty) # needs sage.numerical.mip |
|
|
||
| sage: g=graphs.SwitchedSquaredSkewHadamardMatrixGraph(4) | ||
| sage: g.is_strongly_regular(parameters=True) | ||
| sage: g = graphs.SwitchedSquaredSkewHadamardMatrixGraph(4) # needs sage.modules |
5 tasks
Contributor
Author
|
Thank you! |
Member
|
There is a 💩 in src/sage/graphs/generators/smallgraphs.py which is probably also why the CI fails. Can we avoid settings positive review in that case? |
Contributor
Author
|
Sorry about this. Probably we should have a linter that checks for conflict markers. |
|
Documentation preview for this PR (built with commit 4d259d4; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from
Part of
📝 Checklist
⌛ Dependencies