sage.categories: Update # needs#35945
Merged
vbraun merged 43 commits intosagemath:developfrom Aug 27, 2023
Merged
Conversation
added 29 commits
August 13, 2023 09:24
…combinat[modules]' --only-tags --probe=sage.rings.finite_rings --overwrite
…y-tags --overwrite src/sage/categories/discrete_valuation.py
…y-tags --overwrite src/sage/categories/finite_dimensional_lie_algebras_with_basis.py
…rwrite src/sage/categories/finite_dimensional_lie_algebras_with_basis.py
…ntl' when GF2X is used
…only-tags src/sage/categories/**/*.{py,pyx}
…be all src/sage/categories
dcoudert
suggested changes
Aug 14, 2023
Contributor
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
I did my best but may have missed some details in this giant PR...
| sage: f = lambda part: 2 * s(part.conjugate()) # optional - sage.combinat sage.modules | ||
| sage: s._apply_module_endomorphism(s([2,1]) + s([1,1,1]), f) # optional - sage.combinat sage.modules | ||
| sage: s = SymmetricFunctions(QQ).schur() # needs sage.combinat sage.modules | ||
| sage: f = lambda part: 2 * s(part.conjugate()) |
Contributor
There was a problem hiding this comment.
s needs sage.combinat sage.modules
Contributor
Author
There was a problem hiding this comment.
This is just a definition of a lambda function, it does not need the binding of s
Contributor
Author
There was a problem hiding this comment.
But I have made some improvements to the file in 8b8164d
added 14 commits
August 16, 2023 14:37
…misplaced # needs sage.symbolic
…age.rings.finite_rings
…]' --probe sage.combinat
… use sage.combinat
…e more block tags, fix some tags
|
Documentation preview for this PR (built with commit f29be5a; changes) is ready! 🎉 |
dcoudert
approved these changes
Aug 17, 2023
Contributor
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
I propose to accept this PR. It improves many parts of the code. Further cosmetic improvements can be done in future PRs. This one is already big enough.
LGTM.
Contributor
Author
|
Thank you very much! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 23, 2023
sagemathgh-35945: `sage.categories`: Update `# needs` <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> - Part of: sagemath#29705 - Cherry-picked from: sagemath#35095 <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35945 Reported by: Matthias Köppe Reviewer(s): David Coudert, Matthias Köppe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies