sage.groups.perm_gps.partn_ref*: Modularization fixes#35881
sage.groups.perm_gps.partn_ref*: Modularization fixes#35881vbraun merged 5 commits intosagemath:developfrom
sage.groups.perm_gps.partn_ref*: Modularization fixes#35881Conversation
…pport code, avoid use of FLINT
| """ | ||
| cdef int i = 0, j = 0, location = 0, n = PS.degree | ||
| bitset_zero(b) | ||
| while 1: |
There was a problem hiding this comment.
while True might be better.
Furthermore, this loop has no control on the max value of I . Isn't it safer to use a for loop combined with a else statement to raise an error in case break is never called ?
There was a problem hiding this comment.
I've made these (and other) style fixes.
I also tested with an assert i < PS.degree at the end of the while loops and ran the tests for the faulty random seed reported in https://groups.google.com/g/sage-release/c/4mtUN8Rz92o/m/FLXKh321BgAJ; the assertion held, so at least this is not related.
I don't think I want to put the assertion there permanently though
|
Documentation preview for this PR (built with commit 526efac; changes) is ready! 🎉 |
|
Thank you! |
3 participants
📚 Description
partn_ref2depends onsage.libs.gap.We restore the independence of
partn_reffromsage.libs.gapby creating a separate function for the case ofPS_first_smallestwith non-Nonepartn_ref_alginpartn_ref2.We also remove the compile-time dependency on flint.
📝 Checklist
⌛ Dependencies