Skip to content

Comments

Ensure GCD in normalize_coordinates for projective morphisms#35809

Merged
vbraun merged 8 commits intosagemath:developfrom
guojing0:normalize_coor
Jul 1, 2023
Merged

Ensure GCD in normalize_coordinates for projective morphisms#35809
vbraun merged 8 commits intosagemath:developfrom
guojing0:normalize_coor

Conversation

@guojing0
Copy link
Contributor

@guojing0 guojing0 commented Jun 22, 2023 •
edited
Loading

📚 Description

This PR also attempts to address and fixes #35797.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@guojing0 guojing0 self-assigned this Jun 22, 2023
@guojing0
Copy link
Contributor Author

guojing0 commented Jun 22, 2023

In current implementation, 3 tests will still throw the following error:

TypeError: not a constant polynomial

@guojing0 guojing0 requested a review from bhutz June 22, 2023 20:09
@kwankyu
Copy link
Collaborator

kwankyu commented Jun 22, 2023

3 doctests failed.

@kwankyu kwankyu mentioned this pull request Jun 22, 2023
Merged
5 tasks
@guojing0 guojing0 added this to the sage-10.1 milestone Jun 23, 2023
@bhutz
Copy link
Contributor

bhutz commented Jun 23, 2023

Sorry, I'm still getting used to github, so I'm not I'm asking this correctly. This PR does not seem to be linked to the issue (#35797). Can you fix that?

@guojing0
Copy link
Contributor Author

guojing0 commented Jun 23, 2023 •
edited
Loading

Sorry, I'm still getting used to github, so I'm not I'm asking this correctly. This PR does not seem to be linked to the issue (#35797). Can you fix that?

I think in GitHub, the way to "link" to a specific issue is to mention or @ it, which I did in the description. So at the end of #35797, you can see "@guojing0 mentioned this issue Jun 22, 2023"

When this PR is merged eventually, we then can close that issue manually.

bhutz
bhutz reviewed Jun 26, 2023
View reviewed changes
@guojing0
projective_morphism.py: Restore LCM for elts not in number fields and…
89fde7a 
… create the right ideals for a list of polys
@bhutz
Copy link
Contributor

bhutz commented Jun 27, 2023

This is looking good. I wasn't able to think of any examples where it didn't do what it claims to do. Looks like all tests passed the automated checks and my local tests.

Just one thing. In the new examples add the standard: 'checks that #35797 is fixed' in the docs.

@guojing0
Copy link
Contributor Author

guojing0 commented Jun 27, 2023

Done.

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Documentation preview for this PR (built with commit 6425e9e; changes) is ready! 🎉

@vbraun vbraun merged commit 65ceff8 into sagemath:develop Jul 1, 2023
@guojing0 guojing0 deleted the normalize_coor branch July 2, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bhutz bhutz bhutz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@guojing0 guojing0

Labels

c: algebraic geometry t: bug

Projects

None yet

Milestone

sage-10.1

Development

Successfully merging this pull request may close these issues.

normalize_coordinates for projective morphisms gcd failure

5 participants

@guojing0 @kwankyu @bhutz @vbraun @mkoeppe