cython-lint : removing unused imports in polynomials#35672
Merged
vbraun merged 1 commit intosagemath:developfrom Jun 3, 2023
Merged
cython-lint : removing unused imports in polynomials#35672vbraun merged 1 commit intosagemath:developfrom
vbraun merged 1 commit intosagemath:developfrom
Conversation
|
Documentation preview for this PR (built with commit 27525f9) is ready! 🎉 |
mkoeppe
approved these changes
May 23, 2023
vbraun
pushed a commit
that referenced
this pull request
Jun 21, 2023
gh-35564: `sage.misc.misc`, `sage.combinat`: Modularization fixes <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> - move `powerset` (= `subsets`) from the problematic `sage.misc.misc` module to `sage.combinat.subset`, - likewise we move the implementation of `uniq` (`sage.misc.misc._stable_uniq`) and finish the job from #27014, - we remove `sage.misc.misc.union`, deprecated in #16604, - some other fixes to imports. <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> Part of: - #29705 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> - Depends on #35672 <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35564 Reported by: Matthias Köppe Reviewer(s): David Coudert, Matthias Köppe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
This is removing many unused imports in the pyx files inside
rings/polynomial.All were foudn using
cython-lint | grep "imported but unused"📝 Checklist
⌛ Dependencies