Remove abuse of predefined x in doctests#35648
Merged
vbraun merged 6 commits intosagemath:developfrom Jun 3, 2023
Merged
Conversation
fchapoton
approved these changes
May 25, 2023
Contributor
Author
|
Thank you! May I set to "positive review"? |
Contributor
|
yes, yes. I would have done that, but my keyboard decided to be in strike. By the way, the diff is too large to be seen easily with github viewer. And I do not like all these "internal optional tags" that pollute the doctests. |
Contributor
Author
|
Thanks!
Sorry for the megapatch...
Yes, it's not pretty. I'm trying to pay for it by reformatting poorly formatted doctests and docstrings in return... |
Member
|
Merge conflict |
Contributor
Author
|
trivial merge |
|
Documentation preview for this PR (built with commit 2909357) is ready! 🎉 |
fchapoton
approved these changes
May 28, 2023
Contributor
Author
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Fixes Remove abuse of predefined x in doctests #32721
See also: Deprecate the misuse of symbolic variables as polynomial variable #10483
📝 Checklist
⌛ Dependencies