sage.manifolds, sage.tensor: Add # optional doctest tags for modularization#35267
Merged
vbraun merged 15 commits intosagemath:developfrom Apr 1, 2023
Merged
Conversation
added 12 commits
March 5, 2023 15:04
…date=format:%Y FILE | sort -k2"
|
Documentation preview for this PR is ready! 🎉 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35267 +/- ##
===========================================
+ Coverage 88.57% 88.58% +0.01%
===========================================
Files 2140 2141 +1
Lines 397273 397416 +143
===========================================
+ Hits 351891 352061 +170
+ Misses 45382 45355 -27
... and 26 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
egourgoulhon
approved these changes
Mar 13, 2023
Member
egourgoulhon
left a comment
egourgoulhon
left a comment
There was a problem hiding this comment.
LGTM for sage.manifolds and sage.tensor parts.
Contributor
Author
|
Thank you! |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Adding tags that make it possible/meaningful to doctest
sage.manifolds,sage.tensoreven when some "standard" packages (pplpy, the modularized distribution packaging providingsage.symbolicandsage.manifolds) are not installed. Also taking care ofsage.geometry.riemannian_manifolds.# optionaldoctest tags #34998📝 Checklist
⌛ Dependencies
This is just two commits on top of:
sage.features: Addsage.libs.singular, features for standard Python packages #35237