sage.matrix.operation_table: Modularization and code style fixes#35153
Merged
vbraun merged 3 commits intosagemath:developfrom Mar 26, 2023
Merged
sage.matrix.operation_table: Modularization and code style fixes#35153vbraun merged 3 commits intosagemath:developfrom
sage.matrix.operation_table: Modularization and code style fixes#35153vbraun merged 3 commits intosagemath:developfrom
Conversation
added 2 commits
February 17, 2023 11:51
Codecov ReportBase: 88.59% // Head: 88.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35153 +/- ##
===========================================
- Coverage 88.59% 88.58% -0.01%
===========================================
Files 2140 2140
Lines 396961 396958 -3
===========================================
- Hits 351677 351656 -21
- Misses 45284 45302 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tscrim
requested changes
Feb 18, 2023
Collaborator
tscrim
left a comment
tscrim
left a comment
There was a problem hiding this comment.
Just a few trivial doc formatting things. LGTM otherwise.
Co-authored-by: Travis Scrimshaw <[email protected]>
Contributor
Author
|
Thank you! I've committed these changes. |
|
Documentation preview for this PR is ready! 🎉 |
Contributor
Author
|
Thanks, Dima! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
We remove the module-level dependency of
sage.matrix.operation_tableonmatplotlibandsage.plotand fix some code style issues.It fixes a modularization regression introduced in #8598.
📝 Checklist
⌛ Dependencies