sage.{geometry,rings}: More # optional tags in doctests#35136
Merged
vbraun merged 9 commits intosagemath:developfrom Mar 26, 2023
Merged
sage.{geometry,rings}: More # optional tags in doctests#35136vbraun merged 9 commits intosagemath:developfrom
sage.{geometry,rings}: More # optional tags in doctests#35136vbraun merged 9 commits intosagemath:developfrom
Conversation
Codecov ReportBase: 88.58% // Head: 88.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35136 +/- ##
===========================================
- Coverage 88.58% 88.45% -0.13%
===========================================
Files 2140 2140
Lines 396998 397009 +11
===========================================
- Hits 351676 351187 -489
- Misses 45322 45822 +500
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kliem
approved these changes
Feb 15, 2023
kliem
suggested changes
Feb 15, 2023
Contributor
kliem
left a comment
kliem
left a comment
There was a problem hiding this comment.
There are some failing tests, which makes me wonder whether # optional - sage.libs.pari is working at all.
Contributor
Author
|
Indeed the optional tag was not working, fixed now. |
added 8 commits
February 16, 2023 21:17
…oups, sage.plot, sage.rings.number_field, sage.symbolic
…, sage.rings.number_field, sage.symbolic
…viewer fixes to # optional tags
kliem
approved these changes
Feb 18, 2023
Contributor
Author
|
Thank you! |
|
Documentation preview for this PR is ready! 🎉 |
kliem
approved these changes
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Adding more
# optionaltags in doctests so that doctests can be run with modularized distributions.📝 Checklist
⌛ Dependencies