sage.{arith,crypto,databases,dynamics,lfunctions,quadratic_forms}: Replace imports from sage.*.all for namespace packages#35106
Merged
vbraun merged 27 commits intosagemath:developfrom Mar 19, 2023
Conversation
added 10 commits
December 18, 2022 13:40
…xport of is_FiniteField
…precate_is_finitefield SageMath version 9.8.beta6, Release Date: 2022-12-21
Contributor
|
There are build errors here |
…_rings_abc_finitefield__deprecate_is_finitefield
tobiasdiez
suggested changes
Feb 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35106 +/- ##
===========================================
- Coverage 88.62% 88.61% -0.01%
===========================================
Files 2148 2148
Lines 398653 398679 +26
===========================================
- Hits 353308 353292 -16
- Misses 45345 45387 +42
... and 34 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…eprecate_is_finitefield
Contributor
Author
|
There's no work item to be done. |
Contributor
Contributor
Author
|
Yes, I have already explained to you what these changes are doing and why they are in scope. |
…eprecate_is_finitefield SageMath version 10.0.beta3, Release Date: 2023-03-02
…eprecate_is_finitefield SageMath version 10.0.beta4, Release Date: 2023-03-12
…,quadratic_forms}
…Q/;s/ Z as ZZ/ ZZ/;'
added 9 commits
March 12, 2023 18:13
…ate imports from the same module
…unctions,quadratic_forms} | xargs sed -i.bak 's/GCD as gcd/gcd/'
…lfunctions,quadratic_forms} | xargs sed -i.bak 's/XGCD as xgcd/xgcd/'
…nitefield' into t/34955/sage__arith_crypto_databases_dynamics_lfunctions_quadratic_forms___replace_imports_from_sage___all_for_namespace_packages
|
Documentation preview for this PR is ready! 🎉 |
Merged
4 tasks
vbraun
pushed a commit
that referenced
this pull request
Mar 26, 2023
gh-35110: Meta-PR: Replace imports from sage.*.all for namespace packages <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description Fixes #34201 <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes #1337" --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> - Depends on #35090 - Depends on #35098 - Depends on #35099 - Depends on #35105 - Depends on #35106 - Depends on #35107 URL: #35110 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Fixes #34955
📝 Checklist
⌛ Dependencies
Depends on #35119