Skip to content

singular fails factorization over a numberfield (fixed upstream) #872

@sagetrac-mabshoff

Description

@sagetrac-mabshoff

See also http://www.singular.uni-kl.de/forum/viewtopic.php?t=1639

But since it was reported by a Sage user it is worth tracking here:

mabshoff@sage:/tmp/Work-mabshoff/sage-2.8.6/local/bin$ ./valgrind --tool=memcheck --leak-resolution=high ./Singular-3-0-3
==25414== Memcheck, a memory error detector.
==25414== Copyright (C) 2002-2007, and GNU GPL'd, by Julian Seward  et al.
==25414== Using LibVEX rev 1788, a library for dynamic binary translation.
==25414== Copyright (C) 2004-2007, and GNU GPL'd, by OpenWorks LLP.
==25414== Using valgrind-3.3.0.SVN, a dynamic binary instrumentation framework.
==25414== Copyright (C) 2000-2007, and GNU GPL'd, by Julian Seward et al.
==25414== For more details, rerun with: -v
==25414==
                     SINGULAR                             /  Development
 A Computer Algebra System for Polynomial Computations   /   version 3-0-3
                                                       0<
     by: G.-M. Greuel, G. Pfister, H. Schoenemann        \   May 2007
FB Mathematik der Universitaet, D-67653 Kaiserslautern    \
> ring r=(0,a),(x),dp;
> minpoly=a^2+1;
> factorize(x^18+1);
start Factorize2(int_flag=0)
end Factorize2(0)
[1]:
   _[1]=1
   _[2]=x6+(-a)*x3-1
   _[3]=x6+(a)*x3-1
   _[4]=x2+(a)*x-1
   _[5]=x2+(-a)*x-1
   _[6]=x+(-a)
   _[7]=x+(a)
[2]:
   1,1,1,1,1,1,1
> factorize(x^20+1);
start Factorize2(int_flag=0)
==25414== Source and destination overlap in memcpy(0x4214460, 0x4215300, 3752)
==25414==    at 0x4A1DA2B: memcpy (mc_replace_strmem.c:402)
==25414==    by 0x66F7A0: rEALLOc (in /tmp/Work-mabshoff/sage-2.8.6/local/bin/Singular-3-0-3)
==25414==    by 0x669788: omReallocSizeFromSystem (in /tmp/Work-mabshoff/sage-2.8.6/local/bin/Singular-3-0-3)
==25414==    by 0x6698A0: omReallocLarge (in /tmp/Work-mabshoff/sage-2.8.6/local/bin/Singular-3-0-3)
==25414==    by 0x5CA5F6: reallocSize (in /tmp/Work-mabshoff/sage-2.8.6/local/bin/Singular-3-0-3)
==25414==    by 0x4F04E30: __gmpz_realloc (in /tmp/Work-mabshoff/sage-2.8.6/local/lib/libgmp.so.3.4.1)
==25414==    by 0x4EF76FE: __gmpz_add (in /tmp/Work-mabshoff/sage-2.8.6/local/lib/libgmp.so.3.4.1)
==25414==    by 0x654485: InternalInteger::addsame(InternalCF*) (in /tmp/Work-mabshoff/sage-2.8.6/local/bin/Singular-3-0-3)
==25414==    by 0x628FD7: CanonicalForm::operator+=(CanonicalForm const&) (in /tmp/Work-mabshoff/sage-2.8.6/local/bin/Singular-3-0-3)
==25414==    by 0x657B95: InternalPoly::mulAddTermList(term*, term*, CanonicalForm const&, int, term*&, bool) (in /tmp/Work-mabshoff/sage-2.8.6/local/bin/Singular-3-0-3)
==25414==    by 0x657F4E: InternalPoly::mulsame(InternalCF*) (in /tmp/Work-mabshoff/sage-2.8.6/local/bin/Singular-3-0-3)
==25414==    by 0x627D44: CanonicalForm::operator*=(CanonicalForm const&) (in /tmp/Work-mabshoff/sage-2.8.6/local/bin/Singular-3-0-3)

error: no more memory
System 9920k:19584k Appl 8315k/1604k Malloc 8234k/1173k Valloc 512k/431k Pages 57/71 Regions 1:1

halt 14
==25414==
==25414== ERROR SUMMARY: 11 errors from 1 contexts (suppressed: 13 from 2)
==25414== malloc/free: in use at exit: 0 bytes in 0 blocks.
==25414== malloc/free: 0 allocs, 0 frees, 0 bytes allocated.
==25414== For counts of detected errors, rerun with: -v
==25414== All heap blocks were freed -- no leaks are possible.

Cheers,

Michael

Component: packages: standard

Keywords: singular, number, fields, factorization

Issue created by migration from https://trac.sagemath.org/ticket/872

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions