Add pyproject.toml, remove Cython from setup_requires, install_requires#177
Merged
dimpase merged 2 commits intosagemath:mainfrom Sep 21, 2023
Merged
Add pyproject.toml, remove Cython from setup_requires, install_requires#177dimpase merged 2 commits intosagemath:mainfrom
dimpase merged 2 commits intosagemath:mainfrom
Conversation
Author
|
@dimpase This fixes the wheel build. Please review & merge -- as a first step. |
Member
|
From the GitHub Actions it seems the change doesn't take, they still use Cython 3.0? |
Member
|
GH actions are just badly broken here |
Member
|
LGTM, if we ignore GH I think we can merge this one |
Member
|
let me test how it plays with Sage |
Member
|
OK! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #171.
For now, we use "Cython < 3".
Fixes for Cython 3 in separate PRs.