You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This resolves the problem that was detected in #10.
I first removed the workaround where a signature file depends on all the signature files that came before it. Surprisingly, I didn't break any unit tests by doing that. This is something to pay closer attention to in the future.
Next, I've added my failing test case. Then I updated the merge code and my test case worked.
From now on I hope to inspire you to do every next change test driven. This would be a good preparation for the eventual draft PR.
Two more pointers I do want to mention:
Can we start always formatting the code? Because you didn't do this, I'm not able to do it either because it would make a PR diff larger than necessary. (See ancient greek tragedy)
Please consider abandoning the separate ParallelTypeCheckingTests.fsproj project. Your eventual PR will not be merged in using that. It is best to move the bits to the right projects instead.
Can we start always formatting the code? Because you didn't do this, I'm not able to do it either because it would make a PR diff larger than necessary. (See ancient greek tragedy)
Thanks, I've run Fantomas on src/ and the test project now.
This caused some conflicts on this PR, I'll look into resolving them.
Please consider abandoning the separate ParallelTypeCheckingTests.fsproj project. Your eventual PR will not be merged in using that. It is best to move the bits to the right projects instead.
Yes, that project is a temporary measure which allows for a quicker feedback loop by avoiding the need to recompile FSharp.Compiler.Service on every change.
From now on I hope to inspire you to do every next change test driven. This would be a good preparation for the eventual draft PR.
Thanks, that is definitely the right approach. I'll try to stick to it 👍
As noted in #15 , the changes in this PR do break FCS type-checking, so we need to keep looking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This resolves the problem that was detected in #10.
I first removed the workaround where a signature file depends on all the signature files that came before it. Surprisingly, I didn't break any unit tests by doing that. This is something to pay closer attention to in the future.
Next, I've added my failing test case. Then I updated the merge code and my test case worked.
From now on I hope to inspire you to do every next change test driven. This would be a good preparation for the eventual draft PR.
Two more pointers I do want to mention:
ParallelTypeCheckingTests.fsprojproject. Your eventual PR will not be merged in using that. It is best to move the bits to the right projects instead.