Use consistent casing in tag names

safesparrow · safesparrow · commit bca4a4508214 · 2022-10-10T19:09:39.000+01:00
diff --git a/src/Compiler/Driver/ParseAndCheckInputs.fs b/src/Compiler/Driver/ParseAndCheckInputs.fs
@@ -1199,7 +1199,7 @@ let CheckOneInputAux
     cancellable {
         try
             use _ =
-                Activity.Start "ParseAndCheckInputs.CheckOneInput" [| "inputName", inp.FileName |]
+                Activity.Start "ParseAndCheckInputs.CheckOneInput" [| "fileName", inp.FileName |]
 
             CheckSimulateException tcConfig
 
diff --git a/src/Compiler/Facilities/Logger.fs b/src/Compiler/Facilities/Logger.fs
@@ -11,7 +11,7 @@ module Activity =
 
     let private activitySource = new ActivitySource("fsc")
 
-    let Start name (tags:(string * #obj) seq) : IDisposable = 
+    let Start name (tags:(string * string) seq) : IDisposable = 
             let act = activitySource.StartActivity(name)
             for key,value in tags do
                 act.AddTag(key,value) |> ignore
diff --git a/src/Compiler/Facilities/Logger.fsi b/src/Compiler/Facilities/Logger.fsi
@@ -12,4 +12,4 @@ module internal Activity =
 
     val StartNoTags: name: string -> IDisposable
 
-    val Start: name: string -> tags: (string * #obj) seq -> IDisposable
+    val Start: name: string -> tags: (string * string) seq -> IDisposable
diff --git a/src/Compiler/Service/FSharpCheckerResults.fs b/src/Compiler/Service/FSharpCheckerResults.fs
@@ -2491,8 +2491,8 @@ module internal ParseAndCheckFile =
                 Activity.Start
                     "ParseAndCheckFile.CheckOneFile"
                     [|
-                        "mainInputFileName", mainInputFileName
-                        "Length", sourceText.Length.ToString()
+                        "fileName", mainInputFileName
+                        "length", sourceText.Length.ToString()
                     |]
 
             let parsedMainInput = parseResults.ParseTree
diff --git a/src/Compiler/Service/IncrementalBuild.fs b/src/Compiler/Service/IncrementalBuild.fs
@@ -536,7 +536,7 @@ type BoundModel private (tcConfig: TcConfig,
                         // Build symbol keys
                         let itemKeyStore, semanticClassification =
                             if enableBackgroundItemKeyStoreAndSemanticClassification then
-                                use _ = Activity.Start "IncrementalBuild.CreateItemKeyStoreAndSemanticClassification" [|"fileName",fileName|]
+                                use _ = Activity.Start "IncrementalBuild.CreateItemKeyStoreAndSemanticClassification" [|"fileName", fileName|]
                                 let sResolutions = sink.GetResolutions()
                                 let builder = ItemKeyStoreBuilder()
                                 let preventDuplicates = HashSet({ new IEqualityComparer<struct(pos * pos)> with
diff --git a/src/Compiler/Service/service.fs b/src/Compiler/Service/service.fs
@@ -467,7 +467,7 @@ type BackgroundCompiler
     member _.ParseFile(fileName: string, sourceText: ISourceText, options: FSharpParsingOptions, cache: bool, userOpName: string) =
         async {
             use _ =
-                Activity.Start "BackgroundCompiler.ParseFile" [| "filename", fileName; "UserOpName", userOpName; "cache", cache.ToString() |]
+                Activity.Start "BackgroundCompiler.ParseFile" [| "fileName", fileName; "userOpName", userOpName; "cache", cache.ToString() |]
 
             if cache then
                 let hash = sourceText.GetHashCode() |> int64
@@ -494,7 +494,7 @@ type BackgroundCompiler
     member _.GetBackgroundParseResultsForFileInProject(fileName, options, userOpName) =
         node {
             use _ =
-                Activity.Start "BackgroundCompiler.GetBackgroundParseResultsForFileInProject" [| "filename", fileName; "UserOpName", userOpName |]
+                Activity.Start "BackgroundCompiler.GetBackgroundParseResultsForFileInProject" [| "fileName", fileName; "userOpName", userOpName |]
 
             let! builderOpt, creationDiags = getOrCreateBuilder (options, userOpName)
 
@@ -523,7 +523,7 @@ type BackgroundCompiler
 
     member _.GetCachedCheckFileResult(builder: IncrementalBuilder, fileName, sourceText: ISourceText, options) =
         node {
-            use _ = Activity.Start "BackgroundCompiler.GetCachedCheckFileResult" [| "filename", fileName |]
+            use _ = Activity.Start "BackgroundCompiler.GetCachedCheckFileResult" [| "fileName", fileName |]
             let hash = sourceText.GetHashCode() |> int64
             let key = (fileName, hash, options)
             let cachedResultsOpt = parseCacheLock.AcquireLock(fun ltok -> checkFileInProjectCache.TryGet(ltok, key))
@@ -630,9 +630,9 @@ type BackgroundCompiler
                 Activity.Start
                     "BackgroundCompiler.CheckFileInProjectAllowingStaleCachedResults"
                     [|
-                        "Project", options.ProjectFileName
-                        "filename", fileName
-                        "UserOpName", userOpName
+                        "project", options.ProjectFileName
+                        "fileName", fileName
+                        "userOpName", userOpName
                     |]
 
             let! cachedResults =

Original file line number	Diff line number	Diff line change
`@@ -12,4 +12,4 @@ module internal Activity =`
`12`	`12`
`13`	`13`	`val StartNoTags: name: string -> IDisposable`
`14`	`14`
`15`		`- val Start: name: string -> tags: (string * #obj) seq -> IDisposable`
	`15`	`+ val Start: name: string -> tags: (string * string) seq -> IDisposable`