Add some options with some refactoring#588
Merged
sabrogden merged 9 commits intosabrogden:masterfrom Jan 5, 2024
Merged
Conversation
Contributor
Author
|
I changed GetAvailableTypes function to use EnumClipboardFormats API to keep all types. (but excluded CF_MAX format because it is not valid) |
27b073a to
ca4221b
Compare
sabrogden
approved these changes
Jan 5, 2024
Owner
|
in void CCopyThread::OnClipboardChange(CString activeWindow, CString activeWindowTitle) i don't see any reason to always call oleData.GetAvailableTypes(); it's only used if they are using a copy buffer or the new option to save all. Can we only do this when needed. |
Contributor
Author
|
Oh, It was my miss. I'll update it together with FocusCaret fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for solving #584 added some options.
About GetAvailableTypes functions, there is re-check part after get available format using GetNextFormat.Because GetNextFormat has a bug that not return some of formats (especially CF_DIB), it will re-check to cover include at least the standard formats. Refrefactoring things
Happy new year~