Repository navigation
Commit da99206
authored
fix: return error instead of panic when decoding ParquetScan/AvroScan without features (apache#24198)
## Which issue does this PR close?
- Closes apache#24197.
## Rationale for this change
Explained in apache#24197.
## What changes are included in this PR?
I just replaced the three feature-gate `panic!`s in
`datafusion/proto/src/physical_plan/mod.rs` with `not_impl_err!`,
following the existing `ParquetSink` convention in the same file. Also
fixes "a Avro" to "an Avro" in the message.
## Are these changes tested?
Checked the same feature combinations as the `datafusion-proto features`
CI job and ran `cargo test -p datafusion-proto`. Manually verified with
a no-default-features build that decoding panicked before and returns
`NotImplemented` after. No regression test added because the error path
only exists in feature-disabled builds, which CI only runs `cargo check`
on.
## Are there any user-facing changes?
No API changes.1 parent 33f3688 commit da99206
1 file changed
Lines changed: 7 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1082 | 1082 | | |
1083 | 1083 | | |
1084 | 1084 | | |
1085 | | - | |
1086 | | - | |
| 1085 | + | |
| 1086 | + | |
1087 | 1087 | | |
1088 | 1088 | | |
1089 | 1089 | | |
| |||
1418 | 1418 | | |
1419 | 1419 | | |
1420 | 1420 | | |
1421 | | - | |
1422 | | - | |
| 1421 | + | |
| 1422 | + | |
1423 | 1423 | | |
1424 | 1424 | | |
1425 | 1425 | | |
| |||
1448 | 1448 | | |
1449 | 1449 | | |
1450 | 1450 | | |
1451 | | - | |
| 1451 | + | |
| 1452 | + | |
| 1453 | + | |
1452 | 1454 | | |
1453 | 1455 | | |
1454 | 1456 | | |
| |||
0 commit comments