docs: add self-review checklist + Stop phase operating mode (A4+A5+W6)#904
Merged
Conversation
P0 process-hardening from retrospective review (3 of 4): - A4 Codify-then-validate: 3-question gate for new rules - A5 Code-gen self-review: concurrency / default-coupling / failure-mode - W6 Stop phase operating mode: explicit gray-zone table S4 (community skill fixtures backfill) is the remaining P0; tracked separately as it is 2-3 skills × 4 files.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No changes to review compared to main. |
Contributor
PlanGate Review
PlanGate review decision: pass
ポリシー: critical=fail / major=fail-if-required (warn) / minor=comment-only / info=skipped — spec: |
4 tasks
5 tasks
s977043
added a commit
that referenced
this pull request
May 26, 2026
…906) (#907) Defect discovered during v0.57.0 release: kick workflow's GITHUB_TOKEN-authored push cannot trigger downstream pull_request workflows by GitHub design (no-recursion safety), so the release PR stays BLOCKED despite the kick appearing successful. Fix applies "Code-gen self-review" from AGENTS.md (#904): - Failure mode (loud): added a verification step that polls check-runs for 90s and fails the workflow if no non-Vercel checks start. The silent success was the #906 failure pattern. - Default coupling: prefer RELEASE_KICK_PAT secret, fall back to GITHUB_TOKEN with a warning and an immediate exit 1 in the verify step. - Concurrency / auto-detect: preserved from #902. Runbook updated with PAT setup instructions. Local script (scripts/release-please-kick.sh) remains the unconditional fallback — it pushes via user PAT (gh OAuth), bypassing the no-recursion limit. Closes #906.
s977043
added a commit
that referenced
this pull request
May 27, 2026
Per Codex slice judgment: investigate + design, defer impl. This doc resolves the 3 open questions named in execution-context-contract.md replay section. - Option A/B/C analysis (recommend B: additive debug.execution.snapshot) - Drift handling (report, not block) - 3-PR slice plan (pre / test / impl) - Failing integration test spec Codify-then-validate applied to the design itself (AGENTS.md from #904).
3 tasks
s977043
added a commit
that referenced
this pull request
May 27, 2026
Per Codex slice judgment: investigate + design, defer impl. This doc resolves the 3 open questions named in execution-context-contract.md replay section. - Option A/B/C analysis (recommend B: additive debug.execution.snapshot) - Drift handling (report, not block) - 3-PR slice plan (pre / test / impl) - Failing integration test spec Codify-then-validate applied to the design itself (AGENTS.md from #904).
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P0 process-hardening from the multi-perspective review (3 of 4 items). Companion to PR #902 which fixed the immediate defects; this codifies the patterns so the same defects don't recur.
A4. Codify-then-validate
Before merging a new rule, answer 3 questions: failure scenarios / reopen condition / gray zone. The Stop rule in #898 lacked answers to all three → #902 補修. This is the same-session example referenced.
A5. Code-gen self-review
Before merging workflow / script automation, verify: concurrency / default coupling / failure mode. These were the convergent gaps in #900 → #902.
W6. Stop phase operating mode table
Gray-zone matrix: status report (single OK / repeated NG), retrospective (推奨), tidy-ups (NG), retrospective-derived meta PR (reopen #1 — 新情報 で正当, ただし A4/A5 必須).
Files
AGENTS.md— new "Self-Review Checklist" sectiondocs/development/retrospectives/2026-05-21-25.md— operating mode table under existing Stop-on-Stop-JudgeTest plan
node scripts/fix-dashes.mjs --checkcleanS4 (community skill fixtures backfill, 2-3 skill slice) is the remaining P0 — separate PR.