Closed
Conversation
Owner
|
TBH I'm unsure about this PR, because I still plan to maybe, one day, hopefully during my lifetime, create a logo for the app and therefore have a proper favicon. ^^' However this change should be made in the dev folder, not dist, because the content of dist is overwritten each time the app is built from dev. So I'll close this PR for now and I'll take care of it when I work on the other issues you've opened. |
Author
|
Oops, I just tried to make the fix instead of opening yet another issue, but missed that dist was a build! Yes if you get to make an actual logo some day that’d be good as a favicon! But in the meantime it prevents displaying the server’s current favicon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables easily dropping a favicon.ico if anyone wants to have a custom favicon.
Alternative would be to create an option to specify a icon file, but I understand if this is out of scope.