This repository was archived by the owner on Dec 1, 2019. It is now read-only.
Emit declaration files into the correct location based on WebPack's context#136
Open
bryanforbes wants to merge 2 commits intos-panferov:masterfrom
Open
Emit declaration files into the correct location based on WebPack's context#136bryanforbes wants to merge 2 commits intos-panferov:masterfrom
bryanforbes wants to merge 2 commits intos-panferov:masterfrom
Conversation
Owner
|
@bryanforbes thanks for the PR! I need to make some research to find the best way to store declaration files. I'll try not to prolong this. |
gonzofish
added a commit
to gonzofish/angular-librarian
that referenced
this pull request
Mar 1, 2017
There is [an outstanding awesome-typescript-loader issue](s-panferov/awesome-typescript-loader#193) and [an unmerged PR](s-panferov/awesome-typescript-loader#136) which talk to this issue. Seems that, for the .d.ts files, ATL doesn't understand the Webpack context properly when outputting files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the following project structure:
and the following WebPack configuration:
The following directory structure is created:
This pull request updates the declaration file destination calculation to use WebPack's
loaderUtilsto determine where to emit the declaration file. This pull request does not cover "elided" declaration files which will still output with the incorrect path.