Skip to content

Reorganize all integrations to vendor-specific dirs#1697

Merged
rytilahti merged 8 commits intomasterfrom
janitor/reorg_dirs
Jan 27, 2023
Merged

Reorganize all integrations to vendor-specific dirs#1697
rytilahti merged 8 commits intomasterfrom
janitor/reorg_dirs

Conversation

@rytilahti
Copy link
Owner

@rytilahti rytilahti commented Jan 27, 2023 •
edited
Loading

This will move all integrations to their own separate directories named after the vendor name (which is mostly the same as in the model string).

Example structure:

├── zhimi
│   ├── airpurifier
│   │   ├── airfilter_util.py
│   │   ├── airfresh.py
│   │   ├── airpurifier_miot.py
│   │   ├── airpurifier.py
│   │   ├── __init__.py
│   │   └── tests
│   │       ├── __init__.py
│   │       ├── test_airfilter_util.py
│   │       ├── test_airfresh.py
│   │       ├── test_airpurifier_miot.py
│   │       └── test_airpurifier.py
│   ├── fan
│   │   ├── fan.py
│   │   ├── __init__.py
│   │   ├── test_fan.py
│   │   ├── test_zhimi_miot.py
│   │   ├── zhimi_fan.yaml
│   │   └── zhimi_miot.py
│   ├── heater
│   │   ├── heater_miot.py
│   │   ├── heater.py
│   │   ├── __init__.py
│   │   ├── test_heater_miot.py
│   │   └── test_heater.py
│   ├── humidifier
│   │   ├── airhumidifier_miot.py
│   │   ├── airhumidifier.py
│   │   ├── __init__.py
│   │   └── tests
│   │       ├── __init__.py
│   │       ├── test_airhumidifier_miot.py
│   │       └── test_airhumidifier.py
│   └── __init__.py

Fixes #1115

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023 •
edited
Loading

Codecov Report

Merging #1697 (033888c) into master (d6b5fe8) will increase coverage by 1.86%.
The diff coverage is 99.05%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1697      +/-   ##
==========================================
+ Coverage   79.60%   81.46%   +1.86%     
==========================================
  Files         161      197      +36     
  Lines       16149    17910    +1761     
  Branches     3641     3843     +202     
==========================================
+ Hits        12855    14591    +1736     
- Misses       3015     3031      +16     
- Partials      279      288       +9
Impacted Files Coverage Δ
miio/integrations/airdog/airpurifier/__init__.py 100.00% <ø> (ø)
...egrations/airdog/airpurifier/airpurifier_airdog.py 93.82% <ø> (ø)
...irdog/airpurifier/tests/test_airpurifier_airdog.py 100.00% <ø> (ø)
miio/integrations/deerma/humidifier/__init__.py 100.00% <ø> (ø)
...tegrations/deerma/humidifier/airhumidifier_jsqs.py 91.95% <ø> (ø)
...egrations/deerma/humidifier/airhumidifier_mjjsq.py 93.33% <ø> (ø)
...deerma/humidifier/tests/test_airhumidifier_jsqs.py 98.73% <ø> (ø)
...eerma/humidifier/tests/test_airhumidifier_mjjsq.py 100.00% <ø> (ø)
miio/integrations/dmaker/airfresh/__init__.py 100.00% <ø> (ø)
...iio/integrations/dmaker/airfresh/airfresh_t2017.py 96.10% <ø> (ø)
... and 169 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit aeadb4c into master Jan 27, 2023
@rytilahti rytilahti deleted the janitor/reorg_dirs branch January 27, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[meta] Restructure integrations to their own directories

2 participants

@rytilahti @codecov-commenter