Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1494 +/- ##
=========================================
Coverage 82.59% 82.59%
=========================================
Files 142 142
Lines 14009 14033 +24
Branches 1583 3345 +1762
=========================================
+ Hits 11571 11591 +20
- Misses 2219 2222 +3
- Partials 219 220 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing on adding more introspectable properties (follow-up to #1488), this PR adds support for toggleable switches and implements them for
PowerStrip.The home assistant using this information is available at https://github.com/rytilahti/home-assistant/tree/xiaomi_miio/feat/entities_from_upstream
Here is how the powerstrip looks currently in homeassistant:
Next step is adding support for settings (
selectplatform), but it may take a bit longer as I don't have devices to test on prior cleaning up thevacuumplatform integration to use the common facilities.Ping @syssi @Kirmas @starkillerOG - feel free to test and start adding switches to integrations. Let me know if you encounter any issues or think that something should be changed, we can still adjust the API as needed.