Add support for Dreame Vacuum MB1808 1C#1254
Closed
georgievgeorgi wants to merge 2 commits intorytilahti:masterfrom
Closed
Add support for Dreame Vacuum MB1808 1C#1254georgievgeorgi wants to merge 2 commits intorytilahti:masterfrom
georgievgeorgi wants to merge 2 commits intorytilahti:masterfrom
Conversation
The full robot API is implemented in a dictionary which is interpreted by helper functions in DreameVacuumBase. There is also an example which allows to navigate the robot by the keyboard arrows. Even though the coding conventions of the project are not followed, this contribution might be helpful for the project.
augustas2
approved these changes
Jan 7, 2022
Owner
|
Hi and sorry for the late response! Please check out my comment on another dreame model at #1290 (comment) – it would be better to consolidate this PR similarly to have a single dreame miot implementation :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full robot API is implemented in a dictionary which is interpreted
by helper functions in DreameVacuumBase. There is also an example which
allows to navigate the robot by the keyboard arrows.
Even though the coding conventions of the project are not followed, this
contribution might be helpful for the project.