refactor: use Intl.DateTimeFormat for date formatting #409
Conversation
Replace manual date string construction with Intl.DateTimeFormat API Benefits: - More robust timezone handling (using UTC explicitly) - Standards-compliant implementation - Better performance with native browser/Node.js APIs - Future-proof for internationalization needs Implementation details: - Use en-CA locale for YYYY-MM-DD format in formatDate() - Use formatToParts() for flexible formatting in formatDateCompact() - Maintain backward compatibility with existing date formats
|
Warning Rate limit exceeded@ryoppippi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 13 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ryoppippi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've refactored the date formatting functions to leverage the Intl.DateTimeFormat API. This change aims to improve robustness, performance, and future internationalization capabilities by moving away from manual string manipulation and explicitly handling timezones.
Highlights
- Date Formatting Refactor: Replaced manual date string construction in
formatDate()withIntl.DateTimeFormatforYYYY-MM-DDformat. - Compact Date Formatting: Updated
formatDateCompact()to useIntl.DateTimeFormat.formatToParts()for flexible extraction of date components. - Timezone Handling: Ensured explicit UTC timezone usage in all new date formatters to prevent timezone-related discrepancies.
- Benefits: This refactor leads to more robust timezone handling, standards compliance, potential performance improvements, and better future-proofing for internationalization.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ccusage-guide | 804b4ec | Commit Preview URL Branch Preview URL |
Aug 03 2025, 06:03 PM |
There was a problem hiding this comment.
Code Review
This pull request is a great improvement, refactoring date formatting to use the standard Intl.DateTimeFormat API. This makes the code more robust, standards-compliant, and easier to maintain. My main feedback is a suggestion to further simplify the code by removing a redundant Intl.DateTimeFormat instance and making the parsing of date parts slightly more efficient.
| const date = new Date(dateStr); | ||
| const year = date.getFullYear(); | ||
| const month = String(date.getMonth() + 1).padStart(2, '0'); | ||
| const day = String(date.getDate()).padStart(2, '0'); | ||
| const parts = datePartsFormatter.formatToParts(date); | ||
| const year = parts.find(p => p.type === 'year')?.value ?? ''; | ||
| const month = parts.find(p => p.type === 'month')?.value ?? ''; | ||
| const day = parts.find(p => p.type === 'day')?.value ?? ''; |
There was a problem hiding this comment.
This implementation can be simplified and made slightly more efficient. You can remove the separate datePartsFormatter and reuse dateFormatter here. Additionally, you can extract the date parts in a single loop instead of three separate find() calls. This avoids creating a redundant formatter and reduces iterations over the parts array.
const date = new Date(dateStr);
let year = '', month = '', day = '';
for (const part of dateFormatter.formatToParts(date)) {
switch (part.type) {
case 'year':
year = part.value;
break;
case 'month':
month = part.value;
break;
case 'day':
day = part.value;
break;
}
}
The date formatters were using UTC timezone which caused usage data to be grouped incorrectly. For example, usage at 20:00 local time would appear on the next day if the local timezone was behind UTC. This regression was introduced in PR #409 (commit f7c5251) which added explicit UTC timezone to the Intl.DateTimeFormat configuration. The fix removes the hardcoded 'timeZone: UTC' option, allowing the formatters to respect the system's local timezone or the TZ environment variable if set. Changes: - Remove 'timeZone: UTC' from dateFormatter - Remove 'timeZone: UTC' from datePartsFormatter - Update comment to reflect local timezone usage This ensures usage data is grouped by the user's local date boundaries rather than UTC date boundaries.
Summary
This PR refactors date formatting functions to use the standard
Intl.DateTimeFormatAPI instead of manual string construction.Changes
Intl.DateTimeFormatinformatDate()functionformatToParts()for flexible formatting informatDateCompact()functionBenefits
Technical Details
en-CAlocale is used forYYYY-MM-DDformat (Canadian English uses ISO 8601 date format)formatToParts()allows extracting individual date components for custom formattingTesting