Repository navigation
ci: tree-shaking regression guard for the client runtime - #545
Merged
Merged
Conversation
…id#2883) Bundles import-subset fixtures from src/client.js with rxcore external (measuring only this package's tree-shaken contribution) and fails when gzip cost exceeds committed ceilings with ~5% headroom. The compiled-JSX core scenario excludes the hydrate()-installed runtime — the property #544 established and this guard keeps. Co-Authored-By: Claude Fable 5 <[email protected]>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to solidjs/solid#2883's size work and the size-limit tracking landing in the solid repo.
scripts/size-guard.mjsbundles two import-subset scenarios fromsrc/client.jswithrxcoreexternal — measuring only this package's tree-shaken contribution, independent of the consumer's core — and fails CI when the gzip cost exceeds committed ceilings (~5% headroom over today: compiled-JSX core 4,264 gz / ceiling 4,480; full surface 7,575 gz / ceiling 7,950)."_DX_DEV_"is text-replaced tofalsethe same way consumer build pipelines do (esbuilddefinecan't reach string literals). The core scenario's baseline already excludes the hydration runtime per #544 — re-coupling it costs ~450 bytes against 216 of headroom, so it fails loudly. Deliberate feature additions bump the ceiling in the same PR with a stated reason.🤖 Generated with Claude Code