(cont) Add support for deferred closer functions which are not methods#34
Merged
ryanrolds merged 1 commit intoryanrolds:mainfrom Nov 4, 2023
vanntile:main
Merged
(cont) Add support for deferred closer functions which are not methods#34ryanrolds merged 1 commit intoryanrolds:mainfrom vanntile:main
ryanrolds merged 1 commit intoryanrolds:mainfrom
vanntile:main
Conversation
ryanrolds
approved these changes
Nov 4, 2023
Owner
|
Thank you. |
Contributor
Author
|
Thank you for being responsive! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix PR relating to #33 - empty return functions would be assumed to prime handling the closing of rows statements. This is obviously only true if the return instruction's results include one of the relevant types.
As a result, deferred functions which do not close the initial statement would pass without a linter error. I have added a test to verify this case outputs an error.
This probably completes the issue #7