Add support for deferred closer functions which are not methods#33
Merged
ryanrolds merged 1 commit intoryanrolds:mainfrom Nov 3, 2023
vanntile:main
Merged
Add support for deferred closer functions which are not methods#33ryanrolds merged 1 commit intoryanrolds:mainfrom vanntile:main
ryanrolds merged 1 commit intoryanrolds:mainfrom
vanntile:main
Conversation
ryanrolds
approved these changes
Nov 3, 2023
Owner
|
Merging. Thank you. |
Owner
|
I'm adding some tests and double-checking things. I will cut a release after I build some confidence in the changes. |
Owner
|
@vanntile, I think I'm seeing a false negative. Please add a test that confirms not calling close in the deferred closer function is caught by the linter. |
Contributor
Author
|
Ty for the speed. I will verify myself and create a second MR with the needed changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it has been outlined in #7 - some people need to do some checks whenever they close some statements. If these closer functions are deferred, sqlclosecheck marks the rows as not closed. The current PR fixes that mistake. Test included.
I have also renamed a test that was checking a method, but was actually named like it would have been checking a function.