Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ryanofsky/bitcoin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: pr/unlock.2
Choose a base ref
...
head repository: ryanofsky/bitcoin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pr/unlock.3
Choose a head ref
  • 3 commits
  • 7 files changed
  • 1 contributor

Commits on Jan 22, 2020

  1. wallet: Avoid use of Chain::Lock in CWallet::ScanForWalletTransactions 

    This is a step toward removing the Chain::Lock class and reducing cs_main
locking.

This change affects behavior in a few small ways.

- If there's no max_height specified, percentage progress is measured ending at
  wallet last processed block instead of node tip

- More consistent error reporting: Early check to see if start_block is on the
  active chain is removed, so start_block is always read and the triggers an
  error if it's unavailable
    @ryanofsky
    ryanofsky committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    db78092 View commit details
    Browse the repository at this point in the history

  2. wallet: Avoid use of Chain::Lock in CWallet::CreateTransaction 

    This is a step toward removing the Chain::Lock class and reducing cs_main
locking.

This change only affects behavior in the case where wallet last block processed
falls behind the chain tip, where it may set a different lock time.
    @ryanofsky
    ryanofsky committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    f2c69d5 View commit details
    Browse the repository at this point in the history

  3. wallet: Avoid use of Chain::Lock in CWallet::GetKeyBirthTimes 

    This is a step toward removing the Chain::Lock class and reducing cs_main
locking.

This change only affects behavior in the case where wallet last block processed
falls behind the chain tip, where it will treat the last block processed as the
current tip.
    @ryanofsky
    ryanofsky committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    60e6595 View commit details
    Browse the repository at this point in the history
Loading