Skip to content

Move std/multipart exports to std/mime/multipart.ts#2

Closed
nayeemrmn wants to merge 59 commits into
ry:multipartfrom
nayeemrmn:multipart
Closed

Move std/multipart exports to std/mime/multipart.ts#2
nayeemrmn wants to merge 59 commits into
ry:multipartfrom
nayeemrmn:multipart

Conversation

@nayeemrmn

Copy link
Copy Markdown

kevinkassimo and others added 30 commits December 20, 2019 00:04
std/archive/tar.ts:
- Remove FileReader.
- Remove FileWriter.

std/encoding/csv.ts:
- ExtendedParseOptions -> ParseOptions
- HeaderOption -> HeaderOptions
- ParseOptions -> ReadOptions
- readAll() -> readMatrix()

std/encoding/yaml.ts:
- DumpOptions -> StringifyOptions

std/fmt/colors.ts:
- getEnabled() -> getColorEnabled()
- setEnabled() -> setColorEnabled()

std/testing/mod.ts:
- Re-export sibling modules.
This commit moves HTTP client to lazy_static. Effectively HTTP client is shared by whole Deno process and will reuse connections.
tokio_util::run and tokio::run_on_current_thread should accept Future<Output=()> instead of Future<Output=Result<(), ()>>. Currently, all the passed futures have to add Ok(()) or futures::future::ok(()) unnecessarily to call this method.
ry and others added 23 commits January 5, 2020 11:56
* refactored RecursiveLoad - it was renamed to RecursiveModuleLoad, it does not take ownership of isolate anymore - a struct implementing Stream that yields SourceCodeInfo

* untangled module loading logic between RecursiveLoad and isolate - that logic is encapsulated in EsIsolate and RecursiveModuleLoad, where isolate just consumes modules as they become available - does not require to pass Arc<Mutex<Isolate>> around anymore

* removed EsIsolate.mods_ in favor of Modules and moved them inside EsIsolate

* EsIsolate now requires "loader" argument during construction - struct that implements Loader trait

* rewrite first methods on isolate as async
Also restructures the compiler TypeScript files to make them easier to
manage and eventually integrate deno_typescript fully.
Previously Deno.args was ["script.js", "arg1", "arg2"]
Now it is just ["arg1", "arg2"]
BREAKING CHANGE
@nayeemrmn nayeemrmn changed the title Move std/multipart exports to std/mime/multipart.ts WIP: Move std/multipart exports to std/mime/multipart.ts Jan 10, 2020
@nayeemrmn nayeemrmn changed the title WIP: Move std/multipart exports to std/mime/multipart.ts Move std/multipart exports to std/mime/multipart.ts Jan 10, 2020
@ry

ry commented Jan 10, 2020

Copy link
Copy Markdown
Owner

Thanks - can you submit this as a new PR to Denoland/Deno?

@ry ry closed this Jan 10, 2020
ry pushed a commit that referenced this pull request Feb 26, 2023
…land#17856)

Instead of relying on "serde_v8" which is very inefficient in
serializing enums, I'm hand rolling serde for "ModuleMap" data 
that is stored in the V8 snapshot to make ES modules 
snapshottable.

```
// this branch
Benchmark #2: ./target/release/deno run empty.js

  Time (mean ± σ):      21.4 ms ±   0.9 ms    [User: 15.6 ms, System: 6.4 ms]

  Range (min … max):    20.2 ms …  24.4 ms

// main branch
Benchmark #2: ./target/release/deno run empty.js

  Time (mean ± σ):      23.1 ms ±   1.2 ms    [User: 17.0 ms, System: 6.2 ms]

  Range (min … max):    21.0 ms …  26.0 ms

```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.