Skip to content

Add operator 'StartWith' #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 5 commits into from
Nov 27, 2021
Merged

Add operator 'StartWith' #168

mergify merged 5 commits into from
Nov 27, 2021

Conversation

@utilForever
Copy link
Contributor

@utilForever utilForever commented Nov 26, 2021

@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2021

Welcome to rxRust!
We're delighted to have you onboard <3

@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2021

This pull request does not keep the same code style as this project. Could you fix it? 🙏 Switch to the nightly compiler (with rustup rustup default nightly) then run cargo fmt to get more details.

@codecov
Copy link

codecov bot commented Nov 26, 2021 •
edited
Loading

Codecov Report

Merging #168 (0c1e35d) into master (0135d6d) will decrease coverage by 0.01%.
The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   95.73%   95.71%   -0.02%     
==========================================
  Files          62       63       +1     
  Lines        4407     4438      +31     
==========================================
+ Hits         4219     4248      +29     
- Misses        188      190       +2
Impacted Files Coverage Δ
src/ops.rs 100.00% <ø> (ø)
src/ops/start_with.rs 92.59% <92.59%> (ø)
src/observable.rs 96.79% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0135d6d...0c1e35d. Read the comment docs.

M-Adoo
M-Adoo reviewed Nov 27, 2021
View reviewed changes
Copy link
Collaborator

@M-Adoo M-Adoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's looks good to me. And for implement local and shared observable, do you think macro impl_local_shared_both is a better choice?

@utilForever
Copy link
Contributor Author

utilForever commented Nov 27, 2021

@M-Adoo Okay, I'll try it right now. 😉

@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2021

Clippy helps us to improve our Rust code. Could you fix it? 🙏 Run cargo clippy --all-targets --all-features -- -D warnings to get more details.

@utilForever
Copy link
Contributor Author

utilForever commented Nov 27, 2021

@M-Adoo I checked cargo fmt and cargo clippy and saw no warning and error. Could you re-run it? ⛏️

M-Adoo
M-Adoo approved these changes Nov 27, 2021
View reviewed changes
Copy link
Collaborator

@M-Adoo M-Adoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utilForever seems ci network error, I'll rerun it.

@mergify mergify bot merged commit 13e050c into rxRust:master Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@M-Adoo M-Adoo M-Adoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@utilForever @M-Adoo