Skip to content

Add operator 'WithLatestFrom' #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 3 commits into from
Nov 23, 2021
Merged

Add operator 'WithLatestFrom' #165

mergify merged 3 commits into from
Nov 23, 2021

Conversation

@utilForever
Copy link
Contributor

@utilForever utilForever commented Nov 22, 2021

This revisions includes:

p.s. I tried to inspire my implementation on operator 'Zip'.

@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

Welcome to rxRust!
We're delighted to have you onboard <3

@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

This pull request does not keep the same code style as this project. Could you fix it? 🙏 Switch to the nightly compiler (with rustup rustup default nightly) then run cargo fmt to get more details.

@codecov
Copy link

codecov bot commented Nov 22, 2021 •
edited
Loading

Codecov Report

Merging #165 (0e2c68b) into master (ca8ece5) will increase coverage by 0.54%.
The diff coverage is 95.39%.

❗ Current head 0e2c68b differs from pull request most recent head d0c0b50. Consider uploading reports for the commit d0c0b50 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   95.20%   95.75%   +0.54%     
==========================================
  Files          62       62              
  Lines        5175     4400     -775     
==========================================
- Hits         4927     4213     -714     
+ Misses        248      187      -61
Impacted Files Coverage Δ
src/lib.rs 88.05% <ø> (ø)
src/observer.rs 100.00% <ø> (ø)
src/ops.rs 100.00% <ø> (ø)
src/ops/default_if_empty.rs 93.02% <0.00%> (-3.06%) ⬇️
src/ops/take_last.rs 97.43% <ø> (+1.51%) ⬆️
src/ops/take_until.rs 90.76% <0.00%> (+2.53%) ⬆️
src/scheduler.rs 92.42% <ø> (ø)
src/ops/map.rs 94.28% <50.00%> (-1.27%) ⬇️
src/ops/take.rs 94.73% <50.00%> (-0.92%) ⬇️
src/ops/zip.rs 86.11% <50.00%> (-4.02%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25fa7c0...d0c0b50. Read the comment docs.

@utilForever
Copy link
Contributor Author

utilForever commented Nov 22, 2021

@M-Adoo This failure of GitHub Actions is not my fault.

failures:
    ops::observe_on::test::switch_thread

You should check it. 😢

M-Adoo
M-Adoo requested changes Nov 23, 2021
View reviewed changes
Copy link
Collaborator

@M-Adoo M-Adoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's looks good to me. Could you rebase the branch and squash the commits ?

@utilForever
Copy link
Contributor Author

utilForever commented Nov 23, 2021

@M-Adoo I rebased the branch and squashed the commits! 😄

@utilForever utilForever requested a review from M-Adoo November 23, 2021 17:42
@mergify mergify bot merged commit 80fdf8c into rxRust:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@M-Adoo M-Adoo M-Adoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@utilForever @M-Adoo