Skip to content

Add subject 'BehaviorSubject' #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 11 commits into from
Sep 4, 2021
Merged

Add subject 'BehaviorSubject' #153

mergify merged 11 commits into from
Sep 4, 2021

Conversation

@utilForever
Copy link
Contributor

@utilForever utilForever commented Sep 3, 2021

This revisions includes:

p.s. As this is my first PR in this repo, i tried to inspire my implementation on struct 'Subject'.

@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2021

Welcome to rxRust!
We're delighted to have you onboard <3

@M-Adoo
Copy link
Collaborator

M-Adoo commented Sep 3, 2021

Thanks, LGTM, and please update the CHANGELOG.md and MISSING_FEATURES.md

@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2021

This pull request does not keep the same code style as this project. Could you fix it? 🙏 Switch to the nightly compiler (with rustup rustup default nightly) then run cargo fmt to get more details.

@codecov
Copy link

codecov bot commented Sep 3, 2021 •
edited
Loading

Codecov Report

Merging #153 (462bb12) into master (349e50b) will decrease coverage by 0.05%.
The diff coverage is 93.52%.

❗ Current head 462bb12 differs from pull request most recent head 50a5d46. Consider uploading reports for the commit 50a5d46 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   95.29%   95.23%   -0.06%     
==========================================
  Files          57       58       +1     
  Lines        4376     4515     +139     
==========================================
+ Hits         4170     4300     +130     
- Misses        206      215       +9
Impacted Files Coverage Δ
src/lib.rs 88.44% <ø> (ø)
src/subject/local_subject.rs 98.46% <93.33%> (-1.54%) ⬇️
src/subject/shared_subject.rs 97.36% <93.33%> (-2.64%) ⬇️
src/behavior_subject.rs 93.57% <93.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 349e50b...50a5d46. Read the comment docs.

@utilForever
Copy link
Contributor Author

utilForever commented Sep 3, 2021

@M-Adoo Please approve running workflows. ⛓️

@mergify mergify bot merged commit ad9fff6 into rxRust:master Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@M-Adoo M-Adoo M-Adoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@utilForever @M-Adoo