-
-
Notifications
You must be signed in to change notification settings - Fork 208
Draft: signal prototypes #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: signal prototypes #1523
Conversation
☁️ Nx Cloud ReportWe didn't find any information for the current pull request with the commit 4e2a373. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
| import { RxStrategyProvider } from '@rx-angular/cdk/render-strategies'; | ||
| import { Subject } from 'rxjs'; | ||
|
|
||
| @Directive({ selector: '[signalLet]', standalone: true }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, I'd just call it let directive as signals are going to be the recommended approach going forward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would reconsider the ideas in the template in general. The recent releases change a lot and we should adopt to the "modern way".
| } | ||
| } | ||
|
|
||
| function toObservable<T>(input: Signal<T>): Observable<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to remove this in favor of Angular's toObservable?
| get<K extends keyof T>( | ||
| target: SignalStore<T>, | ||
| p: K | string | symbol | ||
| ): Signal<T[K]> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we say Signal<T[K]> but in the initialValue we have signal(val ?? null)
Do we want to have it as Signal<T[K] | null> ?
Description
https://hackmd.io/gf5D1kC0RVKfDrJZXY-V0Q
State
Connect a signal
Computed from state
Signal from state
Effect from state
To be discussed
Template
To be discussed
transitionlike API (as in react concurrent mode) to have a scheduled signal usingRxRenderStrategiesinternally?