Skip to content

Conversation

@jkhsjdhjs
Copy link

Methods _get_shell() and _get_shells() are added similarly to _get_submodel() and _get_submodels(), which were previously added in ffb833b.

Furthermore, when requesting multiple AAS/Submodels, we're now also updating these in _get_all_obj_of_type() before returning them. Finally, updating AAS/Submodel objects is also moved to _get_obj_ts().

Methods `_get_shell()` and `_get_shells()` are added similarly to
`_get_submodel()` and `_get_submodels()`, which were previously added in
ffb833b.

Furthermore, when requesting multiple AAS/Submodels, we're now also
updating these in `_get_all_obj_of_type()` before returning them.
Finally, updating AAS/Submodel objects is also moved to `_get_obj_ts()`.
Copy link

@Frosty2500 Frosty2500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Frosty2500 Frosty2500 merged commit 85d70ac into feature/http_api Apr 3, 2024
@Frosty2500 Frosty2500 deleted the http_api/refactor_aas_retrieval branch April 3, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants