-
Notifications
You must be signed in to change notification settings - Fork 3
adapter.http: AAS SpecificAssetId filtering
#23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapter.http: AAS SpecificAssetId filtering
#23
Conversation
39257db to
3c83221
Compare
jkhsjdhjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work, but the idea is correct. The changes required to make it work should be relatively simple.
Furthermore, I already rebased the branch to resolve conflicts that arose due to #22. Before you continue to work on this, you should do the following to remove the commit you have locally and pull the commit I rebased.
git reset --hard HEAD\^
git pull
|
After you did what @jkhsjdhjs suggested, have a look at the StaticAnalysis Test on this page here: Other than that, the logic seems fine to me. |
8fddc50 to
5ec7766
Compare
e817fd3 to
a46a296
Compare
a46a296 to
216e5b3
Compare
SpecificAssetId filtering
e8368d5 to
a97201c
Compare
jkhsjdhjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The procedure is as follows:
First, it ensures that we have an appropriate method in HTTPApiDecoder to handle decoding base64url-encoded strings into JSON and then into SpecificAssetId instances.
Finally, the modified get_aas_all function to use this new method for filtering based on SpecificAssetIds is like below: