adapter.http: implement submodel repo routes #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frosty2500
changed the title
Frosty2500
changed the title
jkhsjdhjs
suggested changes
Mar 18, 2024
jkhsjdhjs
left a comment
jkhsjdhjs
left a comment
There was a problem hiding this comment.
Looks pretty good overall, just a few things I would change 👍
jkhsjdhjs
suggested changes
Mar 19, 2024
jkhsjdhjs
left a comment
jkhsjdhjs
left a comment
There was a problem hiding this comment.
Just a few minor comments to fix typing and naming.
jkhsjdhjs
reviewed
Mar 19, 2024
jkhsjdhjs
suggested changes
Mar 20, 2024
jkhsjdhjs
left a comment
jkhsjdhjs
left a comment
There was a problem hiding this comment.
One final comment, LGTM otherwise 👍
basyx/aas/adapter/http.py
Outdated
| parent.append(response_elem) | ||
| etree.cleanup_namespaces(parent) | ||
| return etree.tostring(response_elem, xml_declaration=True, encoding="utf-8") | ||
| return etree.tostring(response_elem, xml_declaration=True, encoding=BASE64URL_ENCODING) |
There was a problem hiding this comment.
We shouldn't use BASE64URL_ENCODING here, since this is only used for encoding XML, which is independent of the base64url encoding.
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds URl-Base64 decoding, semanticId filtering and the level specification in the API (core/deep).
Also adds all metadata and reference routes.