Conversation
|
Can you please lint your code? CI is failing. Also, can you add a unit test? |
- Fixed unit tests to support Windows.
Fixed Lint, errors, added tests. Users shouldn't use Int64 on thouse nodejs versions |
|
Any update on this? What's missing to be merged? If it's about tests not passing on Node.js 6 and 8 because they doesn't have BigInt support, I find It totally acceptable to release a Major version and deprecate them, they are outdated anyway... |
| const BufferList = require('../') | ||
| const { Buffer } = require('buffer') | ||
|
|
||
| function tempPath (filename) { |
There was a problem hiding this comment.
maybe just use os.tmpdir() to make this work nicely
|
Suggestions:
|
|
@rvagg in case @yuyaryshev don't provide the changes in a timely fashion, would you accept a new PR from me with them? |
|
yep, but it'd be appropriate to keep attribution of @yuyaryshev's commit(s) in the process though, so pull them in & squash |
My updated PR with your suggestions is at #109, I have preserver @yuyaryshev commits. Can you review, aprove and merge it? :-) |
|
closed by #114, finally released in v6.0.0 https://github.com/rvagg/bl/releases/tag/v6.0.0 thanks for your patience! |
Welcome :-) |
Fixed Lint, errors, added tests.
Tests fail for node 8 and 6 because they don't have Int64.
I don't know how to fix tests for them.
Users shouldn't use Int64 on thouse nodejs versions