Skip to content

Added bigint (Int64) support.#87

Closed
yuyaryshev wants to merge 3 commits intorvagg:masterfrom
yuyaryshev:patch-1
Closed

Added bigint (Int64) support.#87
yuyaryshev wants to merge 3 commits intorvagg:masterfrom
yuyaryshev:patch-1

Conversation

@yuyaryshev
Copy link
Copy Markdown
Contributor

@yuyaryshev yuyaryshev commented Aug 24, 2020

Fixed Lint, errors, added tests.
Tests fail for node 8 and 6 because they don't have Int64.
I don't know how to fix tests for them.

Users shouldn't use Int64 on thouse nodejs versions

@mcollina
Copy link
Copy Markdown
Collaborator

Can you please lint your code? CI is failing. Also, can you add a unit test?

@yuyaryshev
Copy link
Copy Markdown
Contributor Author

Can you please lint your code? CI is failing. Also, can you add a unit test?

Fixed Lint, errors, added tests.
Tests fail for node 8 and 6 because they don't have Int64.
I don't know how to fix tests for them.

Users shouldn't use Int64 on thouse nodejs versions

@piranna
Copy link
Copy Markdown
Contributor

piranna commented Oct 17, 2022

Any update on this? What's missing to be merged? If it's about tests not passing on Node.js 6 and 8 because they doesn't have BigInt support, I find It totally acceptable to release a Major version and deprecate them, they are outdated anyway...

const BufferList = require('../')
const { Buffer } = require('buffer')

function tempPath (filename) {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just use os.tmpdir() to make this work nicely

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rvagg
Copy link
Copy Markdown
Owner

rvagg commented Oct 17, 2022

Suggestions:

  1. fix up that tmp dir thing using os.tmpdir()
  2. Squash the commits focusing on this feature with a proper conventional commits style, e.g. feat: added BigInt (Int64) support.
  3. Remove <= Node.js 12 from CI, IMO we should do 14, 16, 18, and lts/* + current/* (off the top of my head those are the correct aliases, they're a repeat of 18 but they're useful when the universe moves on and we forget to bump versions). Make the commit for this separate, chore!: remove Node.js <= 12 support - the ! is important because we want to make this a semver-major release since we're dropping Node.js 12 support.

@piranna
Copy link
Copy Markdown
Contributor

piranna commented Oct 17, 2022

@rvagg in case @yuyaryshev don't provide the changes in a timely fashion, would you accept a new PR from me with them?

@rvagg
Copy link
Copy Markdown
Owner

rvagg commented Oct 17, 2022

yep, but it'd be appropriate to keep attribution of @yuyaryshev's commit(s) in the process though, so pull them in & squash

@piranna
Copy link
Copy Markdown
Contributor

piranna commented Oct 17, 2022

yep, but it'd be appropriate to keep attribution of @yuyaryshev's commit(s) in the process though, so pull them in & squash

My updated PR with your suggestions is at #109, I have preserver @yuyaryshev commits. Can you review, aprove and merge it? :-)

@rvagg
Copy link
Copy Markdown
Owner

rvagg commented Oct 19, 2022

closed by #114, finally released in v6.0.0 https://github.com/rvagg/bl/releases/tag/v6.0.0

thanks for your patience!

@rvagg rvagg closed this Oct 19, 2022
@piranna
Copy link
Copy Markdown
Contributor

piranna commented Oct 19, 2022

thanks for your patience!

Welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants