Skip to content

cleanup: use shields.io for CI badge#152

Merged
rvagg merged 1 commit intorvagg:masterfrom
david-allison:master
Feb 5, 2025
Merged

cleanup: use shields.io for CI badge#152
rvagg merged 1 commit intorvagg:masterfrom
david-allison:master

Conversation

@david-allison
Copy link
Copy Markdown
Contributor

@david-allison david-allison commented Feb 4, 2025

EDIT: commit introducing `.npmignore` is now reverted

I noticed a few extra files in your npm package, so I took the initiative to cleanup a little.

Screenshot 2025-02-04 at 11 11 40

.npmignore

⚠️ This felt like a simple change and is untested
⚠️ An alternate is an allowlist approach using files in package.json

Badge

The change is visible: https://github.com/david-allison/bl


Updated badge (visually unchanged):
Screenshot 2025-02-04 at 11 30 13

Copy link
Copy Markdown
Owner

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the .npmignore, the badge seems fine though

@david-allison david-allison changed the title cleanup: npm package and CI badge cleanup: use shields.io for CI badge Feb 5, 2025
@david-allison david-allison requested a review from rvagg February 5, 2025 06:54
@rvagg rvagg merged commit 1d8a5b5 into rvagg:master Feb 5, 2025
@rvagg
Copy link
Copy Markdown
Owner

rvagg commented Feb 5, 2025

thanks!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2025

🎉 This PR is included in version 6.0.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants