Conversation
|
No merge commits please, sorry to be pedantic but I really don't want merge commits in the master branch. As per my original suggestion those 3 initial commits should be squashed down to one. Conventional commits messages would be good too for all of them although I see I haven't got auto-releasing set up here yet so I guess it's not as critical. |
|
So:
Is it correct? |
|
Hold off for a bit. I've started #110 and I'll try and sort this one out myself when I've got that landed. |
Ok 👍🏻 |
|
sorry @piranna, I didn't pull in any of your commits to #114 because they didn't apply after I'd done the work on master. I'm going to leave that open until tomorrow before I merge so feel free to PR against that branch if you'd like to get more changes in. I think the only thing remaining was some of your import cleanup; which I'm fine with if you want to do it, it's just not so critical to getting this out. |
|
Yes, there's something missing... the typescript support for Int64 :-P no issues, once I saw you merged #114, I rebased and started working on it :-) |
|
Ah, no, they are there, I was seeing the code in master... My fault. Ok, I'll rebase on top of v6 and see if there's something useful here. |
## [5.1.0](rvagg/bl@v5.0.0...v5.1.0) (2022-10-18) ### Features * added integrated TypeScript typings ([rvagg#108](rvagg#108)) ([433ff89](rvagg@433ff89)) ### Bug Fixes * windows support in tests ([387dfaf](rvagg@387dfaf)) ### Trivial Changes * GH Actions, Dependabot, auto-release, remove Travis ([997f058](rvagg@997f058)) * **no-release:** bump standard from 16.0.4 to 17.0.0 ([rvagg#112](rvagg#112)) ([078bfe3](rvagg@078bfe3))
|
Rebased and pushed, it seems like only there are clean-ups, although there are some changes that are not mine. |
|
🎉 This issue has been resolved in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Updated PR from #87
This PR adds an optional offset to the
readXXmethods to create compatibility with the Node Buffer API https://nodejs.org/api/buffer.html#buffer_buf_readbigint64be_offsetAdded tests
test udpate