Skip to content

Added bigint (Int64) support.#109

Closed
piranna wants to merge 2 commits intorvagg:rvagg/v6from
dyte-in:patch-1
Closed

Added bigint (Int64) support.#109
piranna wants to merge 2 commits intorvagg:rvagg/v6from
dyte-in:patch-1

Conversation

@piranna
Copy link
Copy Markdown
Contributor

@piranna piranna commented Oct 17, 2022

Updated PR from #87

  • Add default read offsets for Node Buffer compatibility

This PR adds an optional offset to the readXX methods to create compatibility with the Node Buffer API https://nodejs.org/api/buffer.html#buffer_buf_readbigint64be_offset

  • Added tests

  • test udpate

@rvagg
Copy link
Copy Markdown
Owner

rvagg commented Oct 18, 2022

No merge commits please, sorry to be pedantic but I really don't want merge commits in the master branch. As per my original suggestion those 3 initial commits should be squashed down to one. Conventional commits messages would be good too for all of them although I see I haven't got auto-releasing set up here yet so I guess it's not as critical.

@piranna
Copy link
Copy Markdown
Contributor Author

piranna commented Oct 18, 2022

So:

  1. rebase on top of master instead of merge with it
  2. squash @yuyaryshev commits in a single one with the proposed commit message

Is it correct?

@rvagg
Copy link
Copy Markdown
Owner

rvagg commented Oct 18, 2022

Hold off for a bit. I've started #110 and I'll try and sort this one out myself when I've got that landed.

@piranna
Copy link
Copy Markdown
Contributor Author

piranna commented Oct 18, 2022

Hold off for a bit.

Ok 👍🏻

@rvagg
Copy link
Copy Markdown
Owner

rvagg commented Oct 18, 2022

sorry @piranna, I didn't pull in any of your commits to #114 because they didn't apply after I'd done the work on master. I'm going to leave that open until tomorrow before I merge so feel free to PR against that branch if you'd like to get more changes in. I think the only thing remaining was some of your import cleanup; which I'm fine with if you want to do it, it's just not so critical to getting this out.

@piranna
Copy link
Copy Markdown
Contributor Author

piranna commented Oct 18, 2022

Yes, there's something missing... the typescript support for Int64 :-P no issues, once I saw you merged #114, I rebased and started working on it :-)

@piranna
Copy link
Copy Markdown
Contributor Author

piranna commented Oct 18, 2022

Ah, no, they are there, I was seeing the code in master... My fault. Ok, I'll rebase on top of v6 and see if there's something useful here.

@piranna piranna changed the base branch from master to rvagg/v6 October 18, 2022 13:01
## [5.1.0](rvagg/bl@v5.0.0...v5.1.0) (2022-10-18)

### Features

* added integrated TypeScript typings ([rvagg#108](rvagg#108)) ([433ff89](rvagg@433ff89))

### Bug Fixes

* windows support in tests ([387dfaf](rvagg@387dfaf))

### Trivial Changes

* GH Actions, Dependabot, auto-release, remove Travis ([997f058](rvagg@997f058))
* **no-release:** bump standard from 16.0.4 to 17.0.0 ([rvagg#112](rvagg#112)) ([078bfe3](rvagg@078bfe3))
@piranna
Copy link
Copy Markdown
Contributor Author

piranna commented Oct 18, 2022

Rebased and pushed, it seems like only there are clean-ups, although there are some changes that are not mine.

@rvagg rvagg closed this in #114 Oct 19, 2022
@github-actions
Copy link
Copy Markdown

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@piranna piranna deleted the patch-1 branch October 19, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants