Repository navigation
fix(cli): report every saved session in session_list total, not just the limited page - #4344
Merged
Merged
Conversation
…the limited page Signed-off-by: kevin9327 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_listsetstotalafter applyinglimit, sototalalways equals the number of returned sessions.ruflo session listthen printsShowing 10 of 10 sessionseven when 30 sessions are saved, and MCP callers can't tell that the list was cut off.This is the same pattern that #4324 fixed for
task_list.Change
mcp-tools/session-tools.ts: count the sessions beforeslice(0, limit)and return that astotal. The returnedsessionsarray, the sort andlimitare unchanged.Tests
New
__tests__/session-list-total.test.ts(tempCLAUDE_FLOW_CWD, 4 sessions saved throughsession_save):limit: 2returns 2 sessions withtotal: 4totalequals the number of returned sessionsBefore the fix the first test fails (
totalis 2); after it, both pass. The other__tests__/session-*.test.tsfiles give the same results with and without the change.This change was prepared with AI assistance; I reviewed the diff and verified it by running the tests above.