Repository navigation
fix(cli): make status tasks list tasks instead of always printing "No tasks" - #4321
Merged
Merged
Conversation
Owner
|
Reviewed the diff: `status: 'all'` was being passed straight into the comma-split status filter (so it literally compared each task's status against the string `"all"`, matching nothing), and the `status tasks` command was reading `t.id`/`t.agent` while `task_list` actually returns `taskId`/`assignedTo` — both bugs explain "No tasks" exactly as described. The fix (treat `'all'` as "skip the filter" in `task-tools.ts`, fix the field names in `status.ts`) is minimal and correctly scoped; the 4 new tests cover the 'all' bypass, that a real status filter still works, and the field mapping end-to-end through the actual `status tasks` command action. CI is fully green (108/108, 0 failures). Merging. |
Merged
meefs
pushed a commit
to meefs/claude-code-flow
that referenced
this pull request
Oct 20, 2026
Minor release (new backward-compatible flags: Grok Build CLI host surface ruvnet#3512, memory list/search tag filter ruvnet#3526) bundled with a round of correctness fixes merged since 3.58.1: memory delete-sync (ruvnet#4138), real AgentDB HNSWIndex replacing the dead getController('hnsw') path with safe exact-search fallback (ruvnet#4249/ruvnet#4322), harness live-process reporting (ruvnet#3521), RaBitQ on-demand index build (ruvnet#4318/ruvnet#4319), metaharness ADR-152 cost-dimension and verdict-band fix (ruvnet#3520), swarm idle-agent heartbeat false-positive (ruvnet#4320), ephemeral-agent termination idempotency (ruvnet#4323), status/task_list field-mapping and total-count fixes (ruvnet#4321/ruvnet#4324). Also fixes the actual cause of broken images/links on npmjs.com/package/ruflo: `ruflo/package.json`'s `repository.directory: "ruflo"` field added an extra path layer on top of the README content (the root README.md, copied in verbatim by `prepublishOnly` at publish time, which is already written with repo-root-relative paths) — every relative image/link resolved to e.g. `raw/main/ruflo/ruflo/assets/...` instead of `raw/main/ruflo/assets/...`. Removed the `directory` field to match claude-flow's own (directory-less) repository entry. A prior PR (ruvnet#4325) fixed `ruflo/README.md`'s own relative paths for anyone browsing that file directly on GitHub, but that file is overwritten by the root README at publish time and was never the actual npm-rendered content. Published to npm: @claude-flow/[email protected], [email protected], [email protected], and standalone @claude-flow/[email protected] (the ruvnet#4249 fix — not part of the 3-package train, published separately per its own leaf's npm presence). All three umbrella packages' latest/alpha/v3alpha dist-tags verified pointing at 3.59.0. Co-Authored-By: RuFlo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruflo status tasksalways prints "No tasks" (or an empty JSON list), even when tasks exist.Two things go wrong:
tasksCommandcallstask_listwithstatus: 'all', buttask_listtreats every comma-separated value as a literal status. No task has the statusall, so everything is filtered out.t.idandt.agent, buttask_listreturnstaskIdandassignedTo(an array), so the ID and Agent columns would be empty even once tasks come back.Changes
mcp-tools/task-tools.ts: intask_list, a status list containingallmeans "no status filter". Real statuses (pending,completed,pending,in_progress, …) work as before.commands/status.ts: thestatus taskstable usestaskIdand joinsassignedTo(shows-when empty).Tests
New
__tests__/status-tasks-all.test.ts(uses a tempCLAUDE_FLOW_CWD):task_listwithstatus: 'all'returns every tasktask_listwith a real status still filtersstatus tasks --format jsonlists every taskstatus taskstable shows the task id and the assigned agentsWithout the fix, 3 of the 4 tests fail; with it all 4 pass. The other task-related suites in
__tests__give the same results as onmain(the only failure,hooks-post-task-graph-edge-2961, also fails onmainhere because it spawns the built CLI).This change was prepared with AI assistance; I reviewed the diff and verified it by running the tests above.